Fix ACP factory typing and override method annotations

Author: prassanna-ravishankar

agentex-server

@@ -0,0 +1 @@
+/Users/prassanna.ravishankar/git/agentex

src/agentex/lib/adk/utils/_modules/client.py

@@ -1,4 +1,5 @@
 import httpx
+from typing import override
 
 from agentex import AsyncAgentex
 from agentex.lib.utils.logging import make_logger
@@ -11,6 +12,7 @@ class EnvAuth(httpx.Auth):
     def __init__(self, header_name="x-agent-api-key"):
         self.header_name = header_name
 
+    @override
     def auth_flow(self, request):
         # This gets called for every request
         env_vars = EnvironmentVariables.refresh()

src/agentex/lib/cli/commands/tasks.py

@@ -56,7 +56,7 @@ def list_running(
     console.print(f"[green]Found {len(running_tasks)} running task(s) for agent '{agent_name}':[/green]")
 
     # Convert to dict with proper datetime serialization
-    serializable_tasks: list[dict[str, Any]] = []
+    serializable_tasks: list[dict[str, Any]] = []  # type: ignore[misc]
     for task in running_tasks:
         try:
             # Use model_dump with mode='json' for proper datetime handling

src/agentex/lib/cli/handlers/agent_handlers.py

@@ -65,14 +65,14 @@ def build_agent(
         # Log build context information for debugging
         logger.info(f"Build context path: {build_context.path}")
         logger.info(
-            f"Dockerfile path: {build_context.path / build_context.dockerfile_path}"
+            f"Dockerfile path: {build_context.path / build_context.dockerfile_path}"  # type: ignore[operator]
         )
 
         try:
             # Prepare build arguments
             docker_build_kwargs = {
                 "context_path": str(build_context.path),
-                "file": str(build_context.path / build_context.dockerfile_path),
+                "file": str(build_context.path / build_context.dockerfile_path),  # type: ignore[operator]
                 "tags": [image_name],
                 "platforms": platforms,
             }

src/agentex/lib/sdk/fastacp/fastacp.py

@@ -52,7 +52,7 @@ def create_agentic_acp(config: AgenticACPConfig, **kwargs) -> BaseACPServer:
             # Extract temporal_address from config if it's a TemporalACPConfig
             temporal_config = kwargs.copy()
             if hasattr(config, "temporal_address"):
-                temporal_config["temporal_address"] = config.temporal_address
+                temporal_config["temporal_address"] = config.temporal_address  # type: ignore[attr-defined]
             return implementation_class.create(**temporal_config)
         else:
             return implementation_class.create(**kwargs)

src/agentex/lib/sdk/fastacp/impl/temporal_acp.py

@@ -1,4 +1,4 @@
-from typing import Callable, AsyncGenerator
+from typing import Callable, AsyncGenerator, override
 from contextlib import asynccontextmanager
 
 from fastapi import FastAPI
@@ -31,6 +31,7 @@ def __init__(
         self._temporal_address = temporal_address
 
     @classmethod
+    @override
     def create(cls, temporal_address: str) -> "TemporalACP":
         logger.info("Initializing TemporalACP instance")
 
@@ -40,7 +41,7 @@ def create(cls, temporal_address: str) -> "TemporalACP":
         logger.info("TemporalACP instance initialized now")
         return temporal_acp
 
-    # This is to override the lifespan function of the base
+    @override
     def get_lifespan_function(self) -> Callable[[FastAPI], AsyncGenerator[None, None]]:
         @asynccontextmanager
         async def lifespan(app: FastAPI):
@@ -59,29 +60,32 @@ async def lifespan(app: FastAPI):
                 )
 
             # Call parent lifespan for agent registration
-            async with super().get_lifespan_function()(app):
+            async with super().get_lifespan_function()(app):  # type: ignore[misc]
                 yield
 
         return lifespan
 
+    @override
     def _setup_handlers(self):
         """Set up the handlers for temporal workflow operations"""
 
         @self.on_task_create
         async def handle_task_create(params: CreateTaskParams) -> None:
             """Default create task handler - logs the task"""
             logger.info(f"TemporalACP received task create rpc call for task {params.task.id}")
-            await self._temporal_task_service.submit_task(agent=params.agent, task=params.task, params=params.params)
+            if self._temporal_task_service is not None:
+                await self._temporal_task_service.submit_task(agent=params.agent, task=params.task, params=params.params)
 
         @self.on_task_event_send
         async def handle_event_send(params: SendEventParams) -> None:
             """Forward messages to running workflows via TaskService"""
             try:
-                await self._temporal_task_service.send_event(
-                    agent=params.agent,
-                    task=params.task,
-                    event=params.event,
-                )
+                if self._temporal_task_service is not None:
+                    await self._temporal_task_service.send_event(
+                        agent=params.agent,
+                        task=params.task,
+                        event=params.event,
+                    )
 
             except Exception as e:
                 logger.error(f"Failed to send message: {e}")