Fix: task cancellation bug - Separate agent and task identification #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix task_cancel method to properly require agent identification - Previously incorrectly assumed task_name == agent_name and task_id == agent_id - Now correctly requires both agent (owner) and task parameters - Updated method signatures across ACPModule, activities, and service layers - Added test documentation showing correct usage pattern BREAKING CHANGE: task_cancel now requires explicit agent_name/agent_id parameter to identify which agent owns the task being cancelled
prassanna-ravishankar
force-pushed
the
fix/task-cancellation
branch
from
03906c5 to
f9a72a9
Compare
felixs8696
approved these changes
Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
task_cancelmethod incorrectly usedtask_nameas theagent_namefor RPC routing, causing cancellation requests to be sent to the wrong agent or fail entirely. This fix separates agent identification (who to send the RPC to) from task identification (which task to cancel within that agent).The fix adds
agent_idandagent_nameparameters to properly route cancellation requests to the correct agent, while task identification parameters are passed in the RPC payload. Both agent and task identification are now required and validated.This ensures task cancellation works correctly across the system without breaking existing API compatibility.