Skip to content

Keep helm overrides command intact if present #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2025
Merged

Keep helm overrides command intact if present #112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/agentex/lib/cli/handlers/deploy_handlers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,8 +260,10 @@ def merge_deployment_configs(
helm_values["global"]["imagePullSecrets"] = pull_secrets
helm_values["imagePullSecrets"] = pull_secrets

# Add dynamic ACP command based on manifest configuration
add_acp_command_to_helm_values(helm_values, manifest, manifest_path)
# Add dynamic ACP command based on manifest configuration if command is not set in helm overrides
helm_overrides_command = agent_env_config and agent_env_config.helm_overrides and "command" in agent_env_config.helm_overrides
if not helm_overrides_command:
add_acp_command_to_helm_values(helm_values, manifest, manifest_path)

print("Deploying with the following helm values: ", helm_values)
return helm_values
Expand Down
Loading