Skip to content

Conversation

@danielmillerp
Copy link
Contributor

@danielmillerp danielmillerp commented Sep 24, 2025

Add open ai agents sdk plugin to enable temporal support

These are added both for the worker and for the start of the workflow per the documentation:
https://github.com/temporalio/sdk-python/tree/main/temporalio/contrib/openai_agents

Testing:

Tested Open AI Agents with Temporal by creating an agent locally and changing SDK source code locally to what is in PR. Correct behavior as far as automatically wrapping Open AI Agents calls as activities and allow for tool use as well as creating activities out of tools.

Tested without using OpenAi agents and not using plugins to make sure change does not break existing behavior and worked fine as well. Also done locally.

This comment was marked as outdated.

@danielmillerp danielmillerp force-pushed the dm/add-temporal-openai-agents-sdk-plugin branch 4 times, most recently from 33fb831 to 24929f6 Compare September 26, 2025 15:57
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

Comments suppressed due to low confidence (1)

src/agentex/lib/core/temporal/workers/worker.py:97

  • The plugins parameter is missing from the Client.connect call in the else branch when metrics_url is provided. This will cause plugins to be ignored when metrics are enabled.
        runtime = Runtime(
            telemetry=TelemetryConfig(metrics=OpenTelemetryConfig(url=metrics_url))
        )
        client = await Client.connect(
            target_host=temporal_address,
            data_converter=custom_data_converter,
            runtime=runtime,
        )

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@danielmillerp danielmillerp force-pushed the dm/add-temporal-openai-agents-sdk-plugin branch from 24929f6 to b5a3250 Compare September 26, 2025 18:51
@danielmillerp danielmillerp force-pushed the dm/add-temporal-openai-agents-sdk-plugin branch from b5a3250 to b18763b Compare September 26, 2025 19:38
@danielmillerp danielmillerp merged commit 7acfc22 into main Sep 29, 2025
9 of 10 checks passed
@danielmillerp danielmillerp deleted the dm/add-temporal-openai-agents-sdk-plugin branch September 29, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants