Skip to content

Conversation

@MichaelSun48
Copy link
Collaborator

Adds a stickyt feedback button to the bottom of the task sidebar:

image

redirects to the new issue page for this repository

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a "Give Feedback" button to the task sidebar that opens a GitHub issues page for users to provide feedback.

  • Imports the MessageSquare icon from lucide-react
  • Adds a handleFeedback callback that opens GitHub issues in a new tab
  • Renders a "Give Feedback" button at the bottom of the sidebar

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +181 to +185
window.open(
'https://github.com/scaleapi/scale-agentex/issues/new',
'_blank',
'noopener,noreferrer'
);
Copy link

Copilot AI Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The third parameter of window.open is for window features (like width, height), not security attributes. To properly apply noopener and noreferrer security attributes with window.open, you need to manually set the opener property to null on the returned window reference. Consider using: const newWindow = window.open('...', '_blank'); if (newWindow) newWindow.opener = null; Alternatively, consider using an anchor tag with rel=\"noopener noreferrer\" which is more straightforward and consistent with other usage in the codebase (see investigate-traces-button.tsx and json-viewer.tsx).

Suggested change
window.open(
'https://github.com/scaleapi/scale-agentex/issues/new',
'_blank',
'noopener,noreferrer'
);
const newWindow = window.open(
'https://github.com/scaleapi/scale-agentex/issues/new',
'_blank'
);
if (newWindow) newWindow.opener = null;

Copilot uses AI. Check for mistakes.
@MichaelSun48 MichaelSun48 merged commit 9fe10b3 into main Nov 3, 2025
9 checks passed
@MichaelSun48 MichaelSun48 deleted the msun/feedbackButton branch November 3, 2025 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants