Added isSecured configuration setting in TransportConfig; cleaned javadocs

Author: artem-v

transport-parent/transport-netty/src/main/java/io/scalecube/transport/netty/tcp/TcpSender.java

@@ -10,7 +10,6 @@
 import reactor.netty.Connection;
 import reactor.netty.channel.BootstrapHandlers;
 import reactor.netty.resources.ConnectionProvider;
-import reactor.netty.tcp.SslProvider;
 import reactor.netty.tcp.TcpClient;
 
 final class TcpSender implements Sender {
@@ -42,18 +41,19 @@ public Mono<Void> send(Message message) {
   }
 
   private TcpClient newTcpClient(SenderContext context, Address address) {
-    return TcpClient.create(ConnectionProvider.newConnection())
-        .runOn(context.loopResources())
-        .host(address.host())
-        .port(address.port())
-        .option(ChannelOption.TCP_NODELAY, true)
-        .option(ChannelOption.SO_KEEPALIVE, true)
-        .option(ChannelOption.SO_REUSEADDR, true)
-        .option(ChannelOption.CONNECT_TIMEOUT_MILLIS, config.connectTimeout())
-        .secure(config.isSecured() ? SslProvider.defaultClientProvider() : null)
-        .bootstrap(
-            b ->
-                BootstrapHandlers.updateConfiguration(
-                    b, "outbound", new TcpChannelInitializer(config.maxFrameLength())));
+    TcpClient tcpClient =
+        TcpClient.create(ConnectionProvider.newConnection())
+            .runOn(context.loopResources())
+            .host(address.host())
+            .port(address.port())
+            .option(ChannelOption.TCP_NODELAY, true)
+            .option(ChannelOption.SO_KEEPALIVE, true)
+            .option(ChannelOption.SO_REUSEADDR, true)
+            .option(ChannelOption.CONNECT_TIMEOUT_MILLIS, config.connectTimeout())
+            .bootstrap(
+                b ->
+                    BootstrapHandlers.updateConfiguration(
+                        b, "outbound", new TcpChannelInitializer(config.maxFrameLength())));
+    return config.isSecured() ? tcpClient.secure() : tcpClient;
   }
 }

transport-parent/transport-netty/src/main/java/io/scalecube/transport/netty/websocket/WebsocketSender.java

@@ -11,7 +11,7 @@
 import reactor.netty.Connection;
 import reactor.netty.http.client.HttpClient;
 import reactor.netty.http.client.WebsocketClientSpec;
-import reactor.netty.tcp.SslProvider;
+import reactor.netty.tcp.TcpClient;
 
 final class WebsocketSender implements Sender {
 
@@ -48,16 +48,18 @@ public Mono<Void> send(Message message) {
   private HttpClient.WebsocketSender newWebsocketSender(SenderContext context, Address address) {
     return HttpClient.newConnection()
         .tcpConfiguration(
-            tcpClient ->
-                tcpClient
-                    .runOn(context.loopResources())
-                    .host(address.host())
-                    .port(address.port())
-                    .option(ChannelOption.TCP_NODELAY, true)
-                    .option(ChannelOption.SO_KEEPALIVE, true)
-                    .option(ChannelOption.SO_REUSEADDR, true)
-                    .option(ChannelOption.CONNECT_TIMEOUT_MILLIS, config.connectTimeout())
-                    .secure(config.isSecured() ? SslProvider.defaultClientProvider() : null))
+            tcpClient -> {
+              TcpClient tcpClient1 =
+                  tcpClient
+                      .runOn(context.loopResources())
+                      .host(address.host())
+                      .port(address.port())
+                      .option(ChannelOption.TCP_NODELAY, true)
+                      .option(ChannelOption.SO_KEEPALIVE, true)
+                      .option(ChannelOption.SO_REUSEADDR, true)
+                      .option(ChannelOption.CONNECT_TIMEOUT_MILLIS, config.connectTimeout());
+              return config.isSecured() ? tcpClient1.secure() : tcpClient1;
+            })
         .websocket(
             WebsocketClientSpec.builder().maxFramePayloadLength(config.maxFrameLength()).build());
   }