Skip to content

Commit e7b108f

Browse files
authored
Merge pull request #336 from scalecube/remove-memeber-id-generator
Removed member-id-generator
2 parents ee6c8a0 + e33d626 commit e7b108f

File tree

2 files changed

+2
-9
lines changed

2 files changed

+2
-9
lines changed

cluster-api/src/main/java/io/scalecube/cluster/ClusterConfig.java

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
import io.scalecube.cluster.transport.api.TransportConfig;
88
import java.util.Optional;
99
import java.util.StringJoiner;
10-
import java.util.UUID;
1110
import java.util.function.Supplier;
1211
import java.util.function.UnaryOperator;
1312
import reactor.core.Exceptions;
@@ -31,7 +30,6 @@ public final class ClusterConfig implements Cloneable {
3130
// Local cluster working via loopback interface (overrides default/LAN settings)
3231
public static final int DEFAULT_LOCAL_METADATA_TIMEOUT = 1_000;
3332

34-
private Supplier<String> memberIdGenerator = () -> UUID.randomUUID().toString().replace("-", "");
3533
private Object metadata;
3634
private int metadataTimeout = DEFAULT_METADATA_TIMEOUT;
3735
private MetadataCodec metadataCodec = MetadataCodec.INSTANCE;
@@ -88,10 +86,6 @@ public static ClusterConfig defaultLocalConfig() {
8886
.metadataTimeout(DEFAULT_LOCAL_METADATA_TIMEOUT);
8987
}
9088

91-
public Supplier<String> memberIdGenerator() {
92-
return memberIdGenerator;
93-
}
94-
9589
/**
9690
* Setter for memberIdGenerator.
9791
*
@@ -100,7 +94,6 @@ public Supplier<String> memberIdGenerator() {
10094
*/
10195
public ClusterConfig memberIdGenerator(Supplier<String> memberIdGenerator) {
10296
ClusterConfig c = clone();
103-
c.memberIdGenerator = memberIdGenerator;
10497
return c;
10598
}
10699

@@ -307,7 +300,6 @@ public ClusterConfig clone() {
307300
@Override
308301
public String toString() {
309302
return new StringJoiner(", ", ClusterConfig.class.getSimpleName() + "[", "]")
310-
.add("memberIdGenerator=" + memberIdGenerator)
311303
.add("metadata=" + metadataAsString())
312304
.add("metadataTimeout=" + metadataTimeout)
313305
.add("metadataCodec=" + metadataCodec)

cluster/src/main/java/io/scalecube/cluster/ClusterImpl.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
import java.util.Objects;
2929
import java.util.Optional;
3030
import java.util.Set;
31+
import java.util.UUID;
3132
import java.util.function.Function;
3233
import java.util.function.Supplier;
3334
import java.util.function.UnaryOperator;
@@ -392,7 +393,7 @@ private Member createLocalMember(Address address) {
392393
.orElseGet(() -> Address.create(address.host(), port));
393394

394395
return new Member(
395-
config.memberIdGenerator().get(),
396+
UUID.randomUUID().toString().replace("-", ""),
396397
config.memberAlias(),
397398
memberAddress,
398399
config.membershipConfig().namespace());

0 commit comments

Comments
 (0)