Throw exception if some configs was not loaded successfully. On first properties load exception will be propagated on higher layer but starting from second load exception will be only logged.

Author: lightZebra

config/src/main/java/io/scalecube/config/ConfigRegistryImpl.java

@@ -380,23 +380,21 @@ private void loadAndNotify() {
     for (String name : sources.keySet()) {
       ConfigSource source = sources.get(name);
 
-      Throwable loadException = null;
-      Map<String, ConfigProperty> configMap = null;
+      final Map<String, ConfigProperty> configMap;
       try {
         configMap = source.loadConfig();
       } catch (Exception e) {
-        loadException = e; // save error occurrence
+        computeConfigLoadStatus(name, source, e);
+        throw e;
       }
 
-      computeConfigLoadStatus(name, source, loadException);
+      computeConfigLoadStatus(name, source, null);
 
-      if (loadException == null) {
-        // populate loaded properties with new field 'source'
-        configMap.forEach(
-            (key, configProperty) ->
-                loadedPropertyMap.putIfAbsent(
-                    key, LoadedConfigProperty.withCopyFrom(configProperty).source(name).build()));
-      }
+      // populate loaded properties with new field 'source'
+      configMap.forEach(
+          (key, configProperty) ->
+              loadedPropertyMap.putIfAbsent(
+                  key, LoadedConfigProperty.withCopyFrom(configProperty).source(name).build()));
     }
 
     List<ConfigEvent> detectedChanges = new ArrayList<>();