Cosmetic changes

Author: artem-v

Issues.md

@@ -1,9 +1,4 @@
 * When sending null in ServiceMessage.data - now it's throwing BadRequest, but before it was
   security-exception. Must be changed back to how it was.
-* ServicePrincipal - as a second constructor parameter must expect Collection of permissions.
-* ServiceRoleDefinition - as a second constructor parameter must expect Collection of permissions.
-* VaultServiceRolesInstaller:
-  * must validate for non-null constructor parameters (check other security classes as well).
-  * ".key" change to ".identity-key"
 * Add debug logs for Auth/Authz error situations.
 * In ServiceMethodInvoker - wrap principalMapper.map(context) into Mono.defer()

services-api/src/main/java/io/scalecube/services/auth/ServicePrincipal.java

@@ -1,6 +1,5 @@
 package io.scalecube.services.auth;
 
-import java.util.Arrays;
 import java.util.Collection;
 import java.util.Objects;
 import java.util.Set;
@@ -10,16 +9,6 @@ public class ServicePrincipal implements Principal {
   private final String role;
   private final Set<String> permissions;
 
-  /**
-   * Constructor.
-   *
-   * @param role service role
-   * @param permissions service permissions
-   */
-  public ServicePrincipal(String role, String... permissions) {
-    this(role, Set.copyOf(Arrays.asList(permissions)));
-  }
-
   /**
    * Constructor.
    *
@@ -28,7 +17,7 @@ public ServicePrincipal(String role, String... permissions) {
    */
   public ServicePrincipal(String role, Set<String> permissions) {
     this.role = role;
-    this.permissions = permissions;
+    this.permissions = Set.copyOf(permissions);
   }
 
   @Override

services-api/src/main/java/io/scalecube/services/methods/ServiceRoleDefinition.java

@@ -1,6 +1,6 @@
 package io.scalecube.services.methods;
 
-import java.util.Arrays;
+import java.util.Collection;
 import java.util.Objects;
 import java.util.Set;
 import java.util.StringJoiner;
@@ -16,26 +16,16 @@ public class ServiceRoleDefinition {
    * @param role service role
    * @param permissions service permissions
    */
-  public ServiceRoleDefinition(String role, String... permissions) {
-    this(role, Set.copyOf(Arrays.asList(permissions)));
-  }
-
-  /**
-   * Constructor.
-   *
-   * @param role service role
-   * @param permissions service permissions
-   */
-  public ServiceRoleDefinition(String role, Set<String> permissions) {
+  public ServiceRoleDefinition(String role, Collection<String> permissions) {
     this.role = role;
-    this.permissions = permissions;
+    this.permissions = Set.copyOf(permissions);
   }
 
   public String role() {
     return role;
   }
 
-  public Set<String> permissions() {
+  public Collection<String> permissions() {
     return permissions;
   }