Removed validation of message in ServiceMethodInvoker.toRequest()

Author: artem-v

Issues.md

@@ -5,7 +5,6 @@
 import io.scalecube.services.api.ServiceMessage;
 import io.scalecube.services.auth.Principal;
 import io.scalecube.services.auth.PrincipalMapper;
-import io.scalecube.services.exceptions.BadRequestException;
 import io.scalecube.services.exceptions.ForbiddenException;
 import io.scalecube.services.exceptions.ServiceException;
 import io.scalecube.services.exceptions.ServiceProviderErrorMapper;
@@ -201,13 +200,6 @@ private Context enhanceRequestContext(
 
   private Object toRequest(ServiceMessage message) {
     final var request = dataDecoder.apply(message, methodInfo.requestType());
-
-    if (!methodInfo.isRequestTypeVoid()
-        && !methodInfo.isRequestTypeServiceMessage()
-        && !request.hasData(methodInfo.requestType())) {
-      throw new BadRequestException("Wrong request data type");
-    }
-
     return methodInfo.isRequestTypeServiceMessage() ? request : request.data();
   }
 

services-api/src/main/java/io/scalecube/services/methods/ServiceMethodInvoker.java

@@ -4,6 +4,7 @@
 import io.scalecube.services.RequestContext;
 import io.scalecube.services.annotations.Inject;
 import io.scalecube.services.api.ServiceMessage;
+import io.scalecube.services.exceptions.BadRequestException;
 import io.scalecube.services.exceptions.ForbiddenException;
 import java.util.stream.LongStream;
 import org.reactivestreams.Publisher;
@@ -34,8 +35,11 @@ public Mono<String> greeting(String name) {
   }
 
   @Override
-  public Mono<GreetingResponse> greetingPojo(GreetingRequest name) {
-    return Mono.just(new GreetingResponse(" hello to: " + name));
+  public Mono<GreetingResponse> greetingPojo(GreetingRequest request) {
+    if (request == null) {
+      throw new BadRequestException("Wrong request");
+    }
+    return Mono.just(new GreetingResponse(" hello to: " + request));
   }
 
   @Override