Skip to content

Commit f49029e

Browse files
authored
Cleanup dependencies (#876)
* Removed jctools-core, bump netty
1 parent 938c497 commit f49029e

File tree

9 files changed

+19
-43
lines changed

9 files changed

+19
-43
lines changed

pom.xml

Lines changed: 5 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -59,15 +59,14 @@
5959
</scm>
6060

6161
<properties>
62-
<scalecube-cluster.version>2.6.18.RC10</scalecube-cluster.version>
63-
<scalecube-security.version>1.0.33.RC1</scalecube-security.version>
62+
<scalecube-cluster.version>2.6.18.RC11</scalecube-cluster.version>
63+
<scalecube-security.version>1.0.33.RC2</scalecube-security.version>
6464

6565
<reactor.version>2020.0.32</reactor.version>
66-
<jackson.version>2.18.0</jackson.version>
67-
<netty.version>4.1.93.Final</netty.version>
66+
<jackson.version>2.18.2</jackson.version>
67+
<netty.version>4.1.117.Final</netty.version>
6868
<rsocket.version>1.1.4</rsocket.version>
6969
<jsr305.version>3.0.2</jsr305.version>
70-
<jctools.version>2.1.2</jctools.version>
7170

7271
<mockito-junit.version>4.6.1</mockito-junit.version>
7372
<junit-jupiter.version>5.8.2</junit-jupiter.version>
@@ -125,7 +124,7 @@
125124
<scope>import</scope>
126125
</dependency>
127126

128-
<!-- Reactor -->
127+
<!-- Netty -->
129128
<dependency>
130129
<groupId>io.netty</groupId>
131130
<artifactId>netty-bom</artifactId>
@@ -165,13 +164,6 @@
165164
<type>pom</type>
166165
<scope>import</scope>
167166
</dependency>
168-
169-
<!-- JCTools -->
170-
<dependency>
171-
<groupId>org.jctools</groupId>
172-
<artifactId>jctools-core</artifactId>
173-
<version>${jctools.version}</version>
174-
</dependency>
175167
</dependencies>
176168
</dependencyManagement>
177169

services-examples/pom.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
<artifactId>scalecube-services-transport-rsocket</artifactId>
2323
<version>${project.version}</version>
2424
</dependency>
25-
2625
<dependency>
2726
<groupId>io.scalecube</groupId>
2827
<artifactId>scalecube-services-transport-jackson</artifactId>

services-gateway/pom.xml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -38,11 +38,6 @@
3838
<artifactId>jackson-databind</artifactId>
3939
</dependency>
4040

41-
<dependency>
42-
<groupId>org.jctools</groupId>
43-
<artifactId>jctools-core</artifactId>
44-
</dependency>
45-
4641
<!-- Tests -->
4742
<dependency>
4843
<groupId>io.scalecube</groupId>

services-gateway/src/main/java/io/scalecube/services/gateway/client/websocket/WebsocketGatewayClientSession.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
import java.time.Duration;
1515
import java.util.Map;
1616
import java.util.StringJoiner;
17-
import org.jctools.maps.NonBlockingHashMapLong;
17+
import java.util.concurrent.ConcurrentHashMap;
1818
import reactor.core.publisher.Mono;
1919
import reactor.core.publisher.Sinks;
2020
import reactor.core.publisher.Sinks.Many;
@@ -39,7 +39,7 @@ public final class WebsocketGatewayClientSession {
3939
private final Connection connection;
4040

4141
// processor by sid mapping
42-
private final Map<Long, Object> inboundProcessors = new NonBlockingHashMapLong<>(1024);
42+
private final Map<Long, Object> inboundProcessors = new ConcurrentHashMap<>(1024);
4343

4444
WebsocketGatewayClientSession(GatewayClientCodec clientCodec, Connection connection) {
4545
this.id = Integer.toHexString(System.identityHashCode(this));

services-gateway/src/main/java/io/scalecube/services/gateway/websocket/WebsocketGatewaySession.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@
1010
import java.util.Collections;
1111
import java.util.HashMap;
1212
import java.util.Map;
13+
import java.util.concurrent.ConcurrentHashMap;
1314
import java.util.function.Predicate;
14-
import org.jctools.maps.NonBlockingHashMapLong;
1515
import reactor.core.Disposable;
1616
import reactor.core.publisher.Flux;
1717
import reactor.core.publisher.Mono;
@@ -25,7 +25,7 @@ public final class WebsocketGatewaySession implements GatewaySession {
2525

2626
private static final Predicate<Object> SEND_PREDICATE = f -> true;
2727

28-
private final Map<Long, Disposable> subscriptions = new NonBlockingHashMapLong<>(1024);
28+
private final Map<Long, Disposable> subscriptions = new ConcurrentHashMap<>(1024);
2929

3030
private final GatewaySessionHandler gatewayHandler;
3131

services-security/src/main/java/io/scalecube/services/security/RegistryBasedAuthenticator.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
import io.scalecube.services.auth.Authenticator;
44
import java.util.Map;
5-
import org.jctools.maps.NonBlockingHashMapLong;
5+
import java.util.concurrent.ConcurrentHashMap;
66
import reactor.core.publisher.Mono;
77

88
/**
@@ -18,7 +18,7 @@ public final class RegistryBasedAuthenticator<T> implements Authenticator<T> {
1818

1919
private final Authenticator<T> authenticator;
2020

21-
private final Map<Long, T> registry = new NonBlockingHashMapLong<>();
21+
private final Map<Long, T> registry = new ConcurrentHashMap<>();
2222

2323
public RegistryBasedAuthenticator(Authenticator<T> authenticator) {
2424
this.authenticator = authenticator;

services/pom.xml

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -20,15 +20,6 @@
2020
<version>${project.version}</version>
2121
</dependency>
2222

23-
<dependency>
24-
<groupId>io.projectreactor</groupId>
25-
<artifactId>reactor-core</artifactId>
26-
</dependency>
27-
<dependency>
28-
<groupId>org.jctools</groupId>
29-
<artifactId>jctools-core</artifactId>
30-
</dependency>
31-
3223
<!-- Tests -->
3324
<dependency>
3425
<groupId>io.scalecube</groupId>
@@ -43,7 +34,6 @@
4334
<version>${project.version}</version>
4435
<scope>test</scope>
4536
</dependency>
46-
4737
<dependency>
4838
<groupId>io.scalecube</groupId>
4939
<artifactId>scalecube-services-transport-jackson</artifactId>

services/src/main/java/io/scalecube/services/registry/ServiceRegistryImpl.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,34 +18,34 @@
1818
import java.util.List;
1919
import java.util.Map;
2020
import java.util.Objects;
21+
import java.util.concurrent.ConcurrentHashMap;
2122
import java.util.concurrent.CopyOnWriteArrayList;
2223
import java.util.function.Predicate;
2324
import java.util.function.UnaryOperator;
2425
import java.util.stream.Stream;
25-
import org.jctools.maps.NonBlockingHashMap;
2626
import reactor.core.scheduler.Scheduler;
2727

2828
public class ServiceRegistryImpl implements ServiceRegistry {
2929

3030
private static final Logger LOGGER = System.getLogger(ServiceRegistryImpl.class.getName());
3131

3232
// todo how to remove it (tags problem)?
33-
private final Map<String, ServiceEndpoint> serviceEndpoints = new NonBlockingHashMap<>();
33+
private final Map<String, ServiceEndpoint> serviceEndpoints = new ConcurrentHashMap<>();
3434
private final List<ServiceInfo> serviceInfos = new CopyOnWriteArrayList<>();
3535

3636
// remote service references by static and dynamic qualifiers
3737

3838
private final Map<String, List<ServiceReference>> serviceReferencesByQualifier =
39-
new NonBlockingHashMap<>();
39+
new ConcurrentHashMap<>();
4040
private final Map<DynamicQualifier, List<ServiceReference>> serviceReferencesByPattern =
41-
new NonBlockingHashMap<>();
41+
new ConcurrentHashMap<>();
4242

4343
// local service method invokers by static and dynamic qualifiers
4444

4545
private final Map<String, List<ServiceMethodInvoker>> methodInvokersByQualifier =
46-
new NonBlockingHashMap<>();
46+
new ConcurrentHashMap<>();
4747
private final Map<DynamicQualifier, List<ServiceMethodInvoker>> methodInvokersByPattern =
48-
new NonBlockingHashMap<>();
48+
new ConcurrentHashMap<>();
4949

5050
public ServiceRegistryImpl() {}
5151

services/src/main/java/io/scalecube/services/routing/RoundRobinServiceRouter.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,12 @@
66
import java.util.List;
77
import java.util.Map;
88
import java.util.Optional;
9+
import java.util.concurrent.ConcurrentHashMap;
910
import java.util.concurrent.atomic.AtomicInteger;
10-
import org.jctools.maps.NonBlockingHashMap;
1111

1212
public class RoundRobinServiceRouter implements Router {
1313

14-
private final Map<String, AtomicInteger> counterByServiceName = new NonBlockingHashMap<>();
14+
private final Map<String, AtomicInteger> counterByServiceName = new ConcurrentHashMap<>();
1515

1616
@Override
1717
public Optional<ServiceReference> route(ServiceRegistry serviceRegistry, ServiceMessage request) {

0 commit comments

Comments
 (0)