Skip to content

Commit 0b74d86

Browse files
authored
feat(serverless): remove default on http-option (scaleway#4152)
1 parent 3a9d72b commit 0b74d86

File tree

8 files changed

+7
-9
lines changed

8 files changed

+7
-9
lines changed

cmd/scw/testdata/test-all-usage-container-container-update-usage.golden

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ ARGS:
2222
[port]
2323
[secret-environment-variables.{index}.key]
2424
[secret-environment-variables.{index}.value]
25-
[http-option=enabled] Configure how HTTP and HTTPS requests are handled (unknown_http_option | enabled | redirected)
25+
[http-option] Configure how HTTP and HTTPS requests are handled (unknown_http_option | enabled | redirected)
2626
[sandbox] Execution environment of the container (unknown_sandbox | v1 | v2)
2727
[local-storage-limit] Local storage limit of the container (in MB)
2828
[region=fr-par] Region to target. If none is passed will use default region from the config (fr-par | nl-ams | pl-waw)

cmd/scw/testdata/test-all-usage-function-function-update-usage.golden

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ ARGS:
1919
[description] Description of the function
2020
[secret-environment-variables.{index}.key]
2121
[secret-environment-variables.{index}.value]
22-
[http-option=enabled] Configure how HTTP and HTTPS requests are handled (unknown_http_option | enabled | redirected)
22+
[http-option] Configure how HTTP and HTTPS requests are handled (unknown_http_option | enabled | redirected)
2323
[sandbox] Execution environment of the function (unknown_sandbox | v1 | v2)
2424
[region=fr-par] Region to target. If none is passed will use default region from the config (fr-par | nl-ams | pl-waw)
2525

docs/commands/container.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,7 @@ scw container container update <container-id ...> [arg=value ...]
199199
| port | | |
200200
| secret-environment-variables.{index}.key | | |
201201
| secret-environment-variables.{index}.value | | |
202-
| http-option | Default: `enabled`<br />One of: `unknown_http_option`, `enabled`, `redirected` | Configure how HTTP and HTTPS requests are handled |
202+
| http-option | One of: `unknown_http_option`, `enabled`, `redirected` | Configure how HTTP and HTTPS requests are handled |
203203
| sandbox | One of: `unknown_sandbox`, `v1`, `v2` | Execution environment of the container |
204204
| local-storage-limit | | Local storage limit of the container (in MB) |
205205
| region | Default: `fr-par`<br />One of: `fr-par`, `nl-ams`, `pl-waw` | Region to target. If none is passed will use default region from the config |

docs/commands/function.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -461,7 +461,7 @@ scw function function update <function-id ...> [arg=value ...]
461461
| description | | Description of the function |
462462
| secret-environment-variables.{index}.key | | |
463463
| secret-environment-variables.{index}.value | | |
464-
| http-option | Default: `enabled`<br />One of: `unknown_http_option`, `enabled`, `redirected` | Configure how HTTP and HTTPS requests are handled |
464+
| http-option | One of: `unknown_http_option`, `enabled`, `redirected` | Configure how HTTP and HTTPS requests are handled |
465465
| sandbox | One of: `unknown_sandbox`, `v1`, `v2` | Execution environment of the function |
466466
| region | Default: `fr-par`<br />One of: `fr-par`, `nl-ams`, `pl-waw` | Region to target. If none is passed will use default region from the config |
467467

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ require (
2626
github.com/mattn/go-isatty v0.0.20
2727
github.com/moby/buildkit v0.13.2
2828
github.com/opencontainers/go-digest v1.0.0
29-
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.30.0.20240918143018-367e0bbfa46e
29+
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.30.0.20241001085744-c3abf300c911
3030
github.com/skratchdot/open-golang v0.0.0-20200116055534-eef842397966
3131
github.com/spf13/cobra v1.8.1
3232
github.com/spf13/pflag v1.0.5

go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -465,8 +465,8 @@ github.com/rogpeppe/go-internal v1.11.0/go.mod h1:ddIwULY96R17DhadqLgMfk9H9tvdUz
465465
github.com/russross/blackfriday/v2 v2.1.0/go.mod h1:+Rmxgy9KzJVeS9/2gXHxylqXiyQDYRxCVz55jmeOWTM=
466466
github.com/sabhiram/go-gitignore v0.0.0-20210923224102-525f6e181f06 h1:OkMGxebDjyw0ULyrTYWeN0UNCCkmCWfjPnIA2W6oviI=
467467
github.com/sabhiram/go-gitignore v0.0.0-20210923224102-525f6e181f06/go.mod h1:+ePHsJ1keEjQtpvf9HHw0f4ZeJ0TLRsxhunSI2hYJSs=
468-
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.30.0.20240918143018-367e0bbfa46e h1:pun/kzFkKXoXMCnx8O63eLDz69uk0ggjV+OAnbjpw3w=
469-
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.30.0.20240918143018-367e0bbfa46e/go.mod h1:o/2twhmcz4HlhtuuubCuwQ/fe+zyzoJR85+02gy04yY=
468+
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.30.0.20241001085744-c3abf300c911 h1:IwmIIQaLdCx38LeWFIJqNqF8qHTCEdSecY5k5D5LI0k=
469+
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.30.0.20241001085744-c3abf300c911/go.mod h1:o/2twhmcz4HlhtuuubCuwQ/fe+zyzoJR85+02gy04yY=
470470
github.com/sclevine/spec v1.4.0 h1:z/Q9idDcay5m5irkZ28M7PtQM4aOISzOpj4bUPkDee8=
471471
github.com/sclevine/spec v1.4.0/go.mod h1:LvpgJaFyvQzRvc1kaDs0bulYwzC70PbiYjC4QnFHkOM=
472472
github.com/secure-systems-lab/go-securesystemslib v0.8.0 h1:mr5An6X45Kb2nddcFlbmfHkLguCE9laoZCUzEEpIZXA=

internal/namespaces/container/v1beta1/container_cli.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -737,7 +737,6 @@ func containerContainerUpdate() *core.Command {
737737
Required: false,
738738
Deprecated: false,
739739
Positional: false,
740-
Default: core.DefaultValueSetter("enabled"),
741740
EnumValues: []string{"unknown_http_option", "enabled", "redirected"},
742741
},
743742
{

internal/namespaces/function/v1beta1/function_cli.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -738,7 +738,6 @@ func functionFunctionUpdate() *core.Command {
738738
Required: false,
739739
Deprecated: false,
740740
Positional: false,
741-
Default: core.DefaultValueSetter("enabled"),
742741
EnumValues: []string{"unknown_http_option", "enabled", "redirected"},
743742
},
744743
{

0 commit comments

Comments
 (0)