test(iam): prevent type assertion from crashing (scaleway#4362)

Author: Codelax

internal/namespaces/iam/v1alpha1/custom_rule_test.go

@@ -8,6 +8,7 @@ import (
 	"github.com/scaleway/scaleway-cli/v2/core"
 	"github.com/scaleway/scaleway-cli/v2/internal/namespaces/account/v3"
 	iam "github.com/scaleway/scaleway-cli/v2/internal/namespaces/iam/v1alpha1"
+	"github.com/scaleway/scaleway-cli/v2/internal/testhelpers"
 )
 
 func Test_createRule(t *testing.T) {
@@ -49,7 +50,7 @@ func Test_deleteRule(t *testing.T) {
 			core.ExecStoreBeforeCmd("Policy", "scw iam policy get {{ .Policy.ID }}"),
 			func(ctx *core.BeforeFuncCtx) error {
 				// Get first Rule ID
-				policy := ctx.Meta["Policy"].(*iam.PolicyGetInterceptorResponse)
+				policy := testhelpers.MapValue[*iam.PolicyGetInterceptorResponse](t, ctx.Meta, "Policy")
 				if len(policy.Rules) != 2 {
 					return errors.New("expected two rules in policy")
 				}

internal/namespaces/iam/v1alpha1/custom_test.go

@@ -7,6 +7,7 @@ import (
 
 	"github.com/scaleway/scaleway-cli/v2/core"
 	iam "github.com/scaleway/scaleway-cli/v2/internal/namespaces/iam/v1alpha1"
+	"github.com/scaleway/scaleway-cli/v2/internal/testhelpers"
 	iamsdk "github.com/scaleway/scaleway-sdk-go/api/iam/v1alpha1"
 )
 
@@ -52,8 +53,10 @@ func Test_SSHKeyCreateCommand(t *testing.T) {
 		),
 		AfterFunc: func(ctx *core.AfterFuncCtx) error {
 			api := iamsdk.NewAPI(ctx.Client)
+			key := testhelpers.Value[*iamsdk.SSHKey](t, ctx.CmdResult)
+
 			return api.DeleteSSHKey(&iamsdk.DeleteSSHKeyRequest{
-				SSHKeyID: ctx.CmdResult.(*iamsdk.SSHKey).ID,
+				SSHKeyID: key.ID,
 			})
 		},
 	}))