docs(instance): add dynamic-ip-required default value (scaleway#4224)

Author: Codelax

cmd/scw/testdata/test-all-usage-instance-server-create-usage.golden

@@ -41,7 +41,7 @@ ARGS:
   [root-volume]                            Local root volume of the server
   [additional-volumes.{index}]             Additional local and block volumes attached to your server
   [ip=new]                                 Either an IP, an IP ID, ('new', 'ipv4', 'ipv6' or 'both') to create new IPs, 'dynamic' to use a dynamic IP or 'none' for no public IP (new | ipv4 | ipv6 | both | dynamic | none | <id> | <address>)
-  [dynamic-ip-required]                    Define if a dynamic IPv4 is required for the Instance. If server has no IPv4, a dynamic one will be allocated.
+  [dynamic-ip-required=true]               Define if a dynamic IPv4 is required for the Instance. If server has no IPv4, a dynamic one will be allocated.
   [tags.{index}]                           Server tags
   [ipv6]                                   Enable IPv6, to be used with routed-ip-enabled=false
   [stopped]                                Do not start server after its creation

docs/commands/instance.md

@@ -1714,7 +1714,7 @@ scw instance server create [arg=value ...]
 | root-volume |  | Local root volume of the server |
 | additional-volumes.{index} |  | Additional local and block volumes attached to your server |
 | ip | Default: `new` | Either an IP, an IP ID, ('new', 'ipv4', 'ipv6' or 'both') to create new IPs, 'dynamic' to use a dynamic IP or 'none' for no public IP (new | ipv4 | ipv6 | both | dynamic | none | <id> | <address>) |
-| dynamic-ip-required |  | Define if a dynamic IPv4 is required for the Instance. If server has no IPv4, a dynamic one will be allocated. |
+| dynamic-ip-required | Default: `true` | Define if a dynamic IPv4 is required for the Instance. If server has no IPv4, a dynamic one will be allocated. |
 | tags.{index} |  | Server tags |
 | ipv6 |  | Enable IPv6, to be used with routed-ip-enabled=false |
 | stopped |  | Do not start server after its creation |

internal/namespaces/instance/v1/custom_server_create.go

@@ -94,8 +94,9 @@ func serverCreateCommand() *core.Command {
 				Default: core.DefaultValueSetter("new"),
 			},
 			{
-				Name:  "dynamic-ip-required",
-				Short: "Define if a dynamic IPv4 is required for the Instance. If server has no IPv4, a dynamic one will be allocated.",
+				Name:    "dynamic-ip-required",
+				Short:   "Define if a dynamic IPv4 is required for the Instance. If server has no IPv4, a dynamic one will be allocated.",
+				Default: core.DefaultValueSetter("true"),
 			},
 			{
 				Name:  "tags.{index}",