Skip to content

Commit 841510a

Browse files
authored
Merge branch 'scaleway:master' into master
2 parents 3e4802c + 06bd350 commit 841510a

File tree

4 files changed

+31
-13
lines changed

4 files changed

+31
-13
lines changed

cmd/scw/testdata/test-all-usage-iam-api-key-update-usage.golden

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ ARGS:
99
access-key Access key to update
1010
[default-project-id] New default Project ID to set
1111
[description] New description to update
12+
[expires-at] New expiration date of the API key
1213

1314
FLAGS:
1415
-h, --help help for update

docs/commands/iam.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -196,6 +196,7 @@ scw iam api-key update <access-key ...> [arg=value ...]
196196
| access-key | Required | Access key to update |
197197
| default-project-id | | New default Project ID to set |
198198
| description | | New description to update |
199+
| expires-at | | New expiration date of the API key |
199200

200201

201202

internal/namespaces/iam/v1alpha1/iam_cli.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2361,6 +2361,13 @@ func iamAPIKeyUpdate() *core.Command {
23612361
Deprecated: false,
23622362
Positional: false,
23632363
},
2364+
{
2365+
Name: "expires-at",
2366+
Short: `New expiration date of the API key`,
2367+
Required: false,
2368+
Deprecated: false,
2369+
Positional: false,
2370+
},
23642371
},
23652372
Run: func(ctx context.Context, args any) (i any, e error) {
23662373
request := args.(*iam.UpdateAPIKeyRequest)

internal/namespaces/redis/v1/custom_cluster.go

Lines changed: 22 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -68,24 +68,33 @@ func clusterCreateBuilder(c *core.Command) *core.Command {
6868
customRequest := argsI.(*redisCreateClusterRequestCustom)
6969
createClusterRequest := customRequest.CreateClusterRequest
7070

71-
for _, customEndpoint := range customRequest.Endpoints {
72-
if customEndpoint.PrivateNetwork == nil {
73-
continue
74-
}
75-
var ipamConfig *redis.EndpointSpecPrivateNetworkSpecIpamConfig
76-
if customEndpoint.PrivateNetwork.EnableIpam {
77-
ipamConfig = &redis.EndpointSpecPrivateNetworkSpecIpamConfig{}
78-
}
71+
if len(customRequest.Endpoints) == 0 {
7972
createClusterRequest.Endpoints = append(
8073
createClusterRequest.Endpoints,
8174
&redis.EndpointSpec{
82-
PrivateNetwork: &redis.EndpointSpecPrivateNetworkSpec{
83-
ID: customEndpoint.PrivateNetwork.ID,
84-
ServiceIPs: customEndpoint.PrivateNetwork.ServiceIPs,
85-
IpamConfig: ipamConfig,
86-
},
75+
PublicNetwork: &redis.EndpointSpecPublicNetworkSpec{},
8776
},
8877
)
78+
} else {
79+
for _, customEndpoint := range customRequest.Endpoints {
80+
if customEndpoint.PrivateNetwork == nil {
81+
continue
82+
}
83+
var ipamConfig *redis.EndpointSpecPrivateNetworkSpecIpamConfig
84+
if customEndpoint.PrivateNetwork.EnableIpam {
85+
ipamConfig = &redis.EndpointSpecPrivateNetworkSpecIpamConfig{}
86+
}
87+
createClusterRequest.Endpoints = append(
88+
createClusterRequest.Endpoints,
89+
&redis.EndpointSpec{
90+
PrivateNetwork: &redis.EndpointSpecPrivateNetworkSpec{
91+
ID: customEndpoint.PrivateNetwork.ID,
92+
ServiceIPs: customEndpoint.PrivateNetwork.ServiceIPs,
93+
IpamConfig: ipamConfig,
94+
},
95+
},
96+
)
97+
}
8998
}
9099

91100
cluster, err := api.CreateCluster(createClusterRequest)

0 commit comments

Comments
 (0)