Skip to content

Commit 897b938

Browse files
fix(containers): update doc descriptions with correct wording (scaleway#4408)
Co-authored-by: Laure-di <[email protected]>
1 parent 55e6356 commit 897b938

9 files changed

+31
-31
lines changed

cmd/scw/testdata/test-all-usage-container-domain-create-usage.golden

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
🎲🎲🎲 EXIT CODE: 0 🎲🎲🎲
22
🟥🟥🟥 STDERR️️ 🟥🟥🟥️
3-
Create a domain name binding for the container with the specified ID.
3+
Create a custom domain for the container with the specified ID.
44

55
USAGE:
66
scw container domain create [arg=value ...]

cmd/scw/testdata/test-all-usage-container-domain-delete-usage.golden

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
🎲🎲🎲 EXIT CODE: 0 🎲🎲🎲
22
🟥🟥🟥 STDERR️️ 🟥🟥🟥️
3-
Delete the domain name binding with the specific ID.
3+
Delete the custom domain with the specific ID.
44

55
USAGE:
66
scw container domain delete <domain-id ...> [arg=value ...]

cmd/scw/testdata/test-all-usage-container-domain-get-usage.golden

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
🎲🎲🎲 EXIT CODE: 0 🎲🎲🎲
22
🟥🟥🟥 STDERR️️ 🟥🟥🟥️
3-
Get a domain name binding for the container with the specified ID.
3+
Get a custom domain for the container with the specified ID.
44

55
USAGE:
66
scw container domain get <domain-id ...> [arg=value ...]

cmd/scw/testdata/test-all-usage-container-domain-list-usage.golden

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
🎲🎲🎲 EXIT CODE: 0 🎲🎲🎲
22
🟥🟥🟥 STDERR️️ 🟥🟥🟥️
3-
List all domain name bindings in a specified region.
3+
List all custom domains in a specified region.
44

55
USAGE:
66
scw container domain list [arg=value ...]

cmd/scw/testdata/test-all-usage-container-domain-usage.golden

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,10 @@ USAGE:
66
scw container domain <command>
77

88
AVAILABLE COMMANDS:
9-
create Create a domain name binding
10-
delete Delete a domain name binding
11-
get Get a domain name binding
12-
list List all domain name bindings
9+
create Create a custom domain
10+
delete Delete a custom domain
11+
get Get a custom domain
12+
list List all custom domains
1313

1414
FLAGS:
1515
-h, --help help for domain

docs/commands/container.md

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,10 @@ This API allows you to manage your Serverless Containers.
1717
- [Update an existing cron](#update-an-existing-cron)
1818
- [Deploy a container](#deploy-a-container)
1919
- [Domain management commands](#domain-management-commands)
20-
- [Create a domain name binding](#create-a-domain-name-binding)
21-
- [Delete a domain name binding](#delete-a-domain-name-binding)
22-
- [Get a domain name binding](#get-a-domain-name-binding)
23-
- [List all domain name bindings](#list-all-domain-name-bindings)
20+
- [Create a custom domain](#create-a-custom-domain)
21+
- [Delete a custom domain](#delete-a-custom-domain)
22+
- [Get a custom domain](#get-a-custom-domain)
23+
- [List all custom domains](#list-all-custom-domains)
2424
- [Namespace management commands](#namespace-management-commands)
2525
- [Create a new namespace](#create-a-new-namespace)
2626
- [Delete an existing namespace](#delete-an-existing-namespace)
@@ -366,9 +366,9 @@ scw container deploy [arg=value ...]
366366
Domain management commands.
367367

368368

369-
### Create a domain name binding
369+
### Create a custom domain
370370

371-
Create a domain name binding for the container with the specified ID.
371+
Create a custom domain for the container with the specified ID.
372372

373373
**Usage:**
374374

@@ -387,9 +387,9 @@ scw container domain create [arg=value ...]
387387

388388

389389

390-
### Delete a domain name binding
390+
### Delete a custom domain
391391

392-
Delete the domain name binding with the specific ID.
392+
Delete the custom domain with the specific ID.
393393

394394
**Usage:**
395395

@@ -407,9 +407,9 @@ scw container domain delete <domain-id ...> [arg=value ...]
407407

408408

409409

410-
### Get a domain name binding
410+
### Get a custom domain
411411

412-
Get a domain name binding for the container with the specified ID.
412+
Get a custom domain for the container with the specified ID.
413413

414414
**Usage:**
415415

@@ -427,9 +427,9 @@ scw container domain get <domain-id ...> [arg=value ...]
427427

428428

429429

430-
### List all domain name bindings
430+
### List all custom domains
431431

432-
List all domain name bindings in a specified region.
432+
List all custom domains in a specified region.
433433

434434
**Usage:**
435435

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ require (
2626
github.com/mattn/go-isatty v0.0.20
2727
github.com/moby/buildkit v0.13.2
2828
github.com/opencontainers/go-digest v1.0.0
29-
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.30.0.20241226101018-6140d56d1e5c
29+
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.30.0.20250108093124-1be16fad27b2
3030
github.com/skratchdot/open-golang v0.0.0-20200116055534-eef842397966
3131
github.com/spf13/cobra v1.8.1
3232
github.com/spf13/pflag v1.0.5

go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -466,8 +466,8 @@ github.com/rogpeppe/go-internal v1.11.0/go.mod h1:ddIwULY96R17DhadqLgMfk9H9tvdUz
466466
github.com/russross/blackfriday/v2 v2.1.0/go.mod h1:+Rmxgy9KzJVeS9/2gXHxylqXiyQDYRxCVz55jmeOWTM=
467467
github.com/sabhiram/go-gitignore v0.0.0-20210923224102-525f6e181f06 h1:OkMGxebDjyw0ULyrTYWeN0UNCCkmCWfjPnIA2W6oviI=
468468
github.com/sabhiram/go-gitignore v0.0.0-20210923224102-525f6e181f06/go.mod h1:+ePHsJ1keEjQtpvf9HHw0f4ZeJ0TLRsxhunSI2hYJSs=
469-
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.30.0.20241226101018-6140d56d1e5c h1:GvJhbvUDbkkz8ts+hmLhv9SPgj/DLaH+Qj7rbxV+jkw=
470-
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.30.0.20241226101018-6140d56d1e5c/go.mod h1:kzh+BSAvpoyHHdHBCDhmSWtBc1NbLMZ2lWHqnBoxFks=
469+
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.30.0.20250108093124-1be16fad27b2 h1:zPlwMJ1eKWpII1TWrasa7/Q+mC1KumZlxyqTQrhHKA8=
470+
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.30.0.20250108093124-1be16fad27b2/go.mod h1:kzh+BSAvpoyHHdHBCDhmSWtBc1NbLMZ2lWHqnBoxFks=
471471
github.com/sclevine/spec v1.4.0 h1:z/Q9idDcay5m5irkZ28M7PtQM4aOISzOpj4bUPkDee8=
472472
github.com/sclevine/spec v1.4.0/go.mod h1:LvpgJaFyvQzRvc1kaDs0bulYwzC70PbiYjC4QnFHkOM=
473473
github.com/secure-systems-lab/go-securesystemslib v0.8.0 h1:mr5An6X45Kb2nddcFlbmfHkLguCE9laoZCUzEEpIZXA=

internal/namespaces/container/v1beta1/container_cli.go

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1137,8 +1137,8 @@ func containerCronDelete() *core.Command {
11371137

11381138
func containerDomainList() *core.Command {
11391139
return &core.Command{
1140-
Short: `List all domain name bindings`,
1141-
Long: `List all domain name bindings in a specified region.`,
1140+
Short: `List all custom domains`,
1141+
Long: `List all custom domains in a specified region.`,
11421142
Namespace: "container",
11431143
Resource: "domain",
11441144
Verb: "list",
@@ -1184,8 +1184,8 @@ func containerDomainList() *core.Command {
11841184

11851185
func containerDomainGet() *core.Command {
11861186
return &core.Command{
1187-
Short: `Get a domain name binding`,
1188-
Long: `Get a domain name binding for the container with the specified ID.`,
1187+
Short: `Get a custom domain`,
1188+
Long: `Get a custom domain for the container with the specified ID.`,
11891189
Namespace: "container",
11901190
Resource: "domain",
11911191
Verb: "get",
@@ -1214,8 +1214,8 @@ func containerDomainGet() *core.Command {
12141214

12151215
func containerDomainCreate() *core.Command {
12161216
return &core.Command{
1217-
Short: `Create a domain name binding`,
1218-
Long: `Create a domain name binding for the container with the specified ID.`,
1217+
Short: `Create a custom domain`,
1218+
Long: `Create a custom domain for the container with the specified ID.`,
12191219
Namespace: "container",
12201220
Resource: "domain",
12211221
Verb: "create",
@@ -1251,8 +1251,8 @@ func containerDomainCreate() *core.Command {
12511251

12521252
func containerDomainDelete() *core.Command {
12531253
return &core.Command{
1254-
Short: `Delete a domain name binding`,
1255-
Long: `Delete the domain name binding with the specific ID.`,
1254+
Short: `Delete a custom domain`,
1255+
Long: `Delete the custom domain with the specific ID.`,
12561256
Namespace: "container",
12571257
Resource: "domain",
12581258
Verb: "delete",

0 commit comments

Comments
 (0)