fix: return error on client creation with empty API URL (scaleway#2533)

Author: Tomy2e

scw/client_option.go

@@ -264,10 +264,10 @@ func (s *settings) validate() error {
 
 	// API URL.
 	if !validation.IsURL(s.apiURL) {
-		return NewInvalidClientOptionError("invalid url %s", s.apiURL)
+		return NewInvalidClientOptionError("invalid API url '%s'", s.apiURL)
 	}
 	if s.apiURL[len(s.apiURL)-1:] == "/" {
-		return NewInvalidClientOptionError("invalid url %s it should not have a trailing slash", s.apiURL)
+		return NewInvalidClientOptionError("invalid API url '%s' it should not have a trailing slash", s.apiURL)
 	}
 
 	// TODO: check for max s.defaultPageSize

scw/client_option_test.go

@@ -67,7 +67,15 @@ func TestClientOptions(t *testing.T) {
 				s.apiURL = ":test"
 				s.token = auth.NewToken(v2ValidAccessKey, v2ValidSecretKey)
 			},
-			errStr: "scaleway-sdk-go: invalid url :test",
+			errStr: "scaleway-sdk-go: invalid API url ':test'",
+		},
+		{
+			name: "Should throw an empty url error",
+			clientOption: func(s *settings) {
+				s.apiURL = ""
+				s.token = auth.NewToken(v2ValidAccessKey, v2ValidSecretKey)
+			},
+			errStr: "scaleway-sdk-go: invalid API url ''",
 		},
 		{
 			name: "Should throw an empty organization ID error",

validation/is.go

@@ -51,6 +51,10 @@ func IsZone(s string) bool {
 
 // IsURL returns true if the given string has a valid URL format.
 func IsURL(s string) bool {
+	if s == "" {
+		return false
+	}
+
 	_, err := url.Parse(s)
 	return err == nil
 }