chore(errors): remove toLower conversion for API error messages (scaleway#2310)

jremy42 · web-flow · commit 774e7f5c535e · 2024-11-19T09:36:43.000Z
diff --git a/scw/errors.go b/scw/errors.go
@@ -50,9 +50,6 @@ func (e *ResponseError) UnmarshalJSON(b []byte) error {
 	if err != nil {
 		return err
 	}
-
-	tmp.Message = strings.ToLower(tmp.Message)
-
 	*e = ResponseError(tmp)
 	return nil
 }
diff --git a/scw/errors_test.go b/scw/errors_test.go
@@ -149,7 +149,7 @@ func TestNonStandardError(t *testing.T) {
 		expectedError: &ResponseError{
 			Status:     "409 Conflict",
 			StatusCode: http.StatusConflict,
-			Message:    "group is in use. you cannot delete it.",
+			Message:    "Group is in use. You cannot delete it.",
 			Type:       "conflict",
 			RawBody:    []byte(`{"message": "Group is in use. You cannot delete it.", "type": "conflict"}`),
 		},

Original file line number	Diff line number	Diff line change
`@@ -50,9 +50,6 @@ func (e *ResponseError) UnmarshalJSON(b []byte) error {`
`50`	`50`	`if err != nil {`
`51`	`51`	`return err`
`52`	`52`	`}`
`53`		`-`
`54`		`- tmp.Message = strings.ToLower(tmp.Message)`
`55`		`-`
`56`	`53`	`*e = ResponseError(tmp)`
`57`	`54`	`return nil`
`58`	`55`	`}`