fix: don't try to read/unmarshal response content when empty (scaleway#2361)

pablo-ruth · Pablo RUTH · web-flow · commit efb548ebcdcb · 2024-12-16T13:09:55.000Z
Co-authored-by: Pablo RUTH &lt;pruth@scaleway.com&gt;
diff --git a/scw/client.go b/scw/client.go
@@ -230,7 +230,7 @@ func (c *Client) do(req *ScalewayRequest, res interface{}) (sdkErr error) {
 		return sdkErr
 	}
 
-	if res != nil {
+	if res != nil && httpResponse.ContentLength > 0 {
 		contentType := httpResponse.Header.Get("Content-Type")
 
 		if strings.HasPrefix(contentType, "application/json") {

Original file line number	Diff line number	Diff line change
`@@ -230,7 +230,7 @@ func (c Client) do(req ScalewayRequest, res interface{}) (sdkErr error) {`
`230`	`230`	`return sdkErr`
`231`	`231`	`}`
`232`	`232`
`233`		`- if res != nil {`
	`233`	`+ if res != nil && httpResponse.ContentLength > 0 {`
`234`	`234`	`contentType := httpResponse.Header.Get("Content-Type")`
`235`	`235`
`236`	`236`	`if strings.HasPrefix(contentType, "application/json") {`