Skip to content

Commit 68d7196

Browse files
RoRoJjcirinosclwy
andauthored
Apply suggestions from code review
Co-authored-by: Jessica <[email protected]>
1 parent 63498d0 commit 68d7196

File tree

5 files changed

+6
-13
lines changed

5 files changed

+6
-13
lines changed

pages/topics-and-events/api-cli/connect-aws-cli.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ Now you have installed the AWS-CLI, you need to configure it for use with Scalew
116116
aws_secret_access_key=<SECRET_KEY>
117117
```
118118

119-
6. Test that everything is set up correctly with the following command:
119+
5. Test that everything is set up correctly with the following command:
120120
```
121121
aws topics_events list-topics
122122
```

pages/topics-and-events/api-cli/topics-events-aws-cli.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ The AWS-CLI is an open-source tool built on top of the AWS SDK for Python (Boto)
4848
aws sns subscribe --topic-arn $(jq -r .TopicArn my-topic.json) --protocol http --notification-endpoint <YOUR-HTTP-ENDPOINT> | tee my-subscription.json
4949
```
5050

51-
3. Find the HTTP request received by the HTTP server. It should have a body in json matching the following format. It contains information necessary to complete the subscription process:
51+
3. Find the HTTP request received by the HTTP server. It should have a body in JSON matching the following format. It contains the information necessary to complete the subscription process:
5252

5353
```json
5454
{

pages/topics-and-events/concepts.mdx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,11 @@ FIFO stands for **F**irst **I**n **F**irst **O**ut, and represents a type of top
2727

2828
## Filtering
2929

30-
In a [topic-based](#topic-based) system, where topics handle the logic, filtering is similar to routing. Messages are sent to defined topics, which can be thought of as filters in so far as subscribers can subscribe only to the topics they are interested in. In a [content-based](#content-based) system, filtering is carried out more directly by subscribers, who define filters for messages based on the content/attributes they want to receive.
30+
In a [topic-based](#topic-based) system, where topics handle the logic, filtering is similar to routing. Messages are sent to defined topics, which can be thought of as filters, as subscribers can subscribe only to the topics they are interested in. In a [content-based](#content-based) system, filtering is carried out more directly by subscribers, who define filters for messages based on the content/attributes they want to receive.
3131

3232
## Message broker
3333

34-
A message broker is a piece of software that allows applications, systems and services to communicate with each other and send/receive data. It facilitates the exchange of information by receiving messages from a producer, and transmitting them to a consumer. Scaleway Topics and Events is a message broker tool based on the AWS SNS messaging system.
34+
A message broker is a piece of software that allows applications, systems, and services to communicate with each other and send/receive data. It facilitates the exchange of information by receiving messages from a producer and transmitting them to a consumer. Scaleway Topics and Events is a message broker tool based on the AWS SNS messaging system.
3535

3636
## Messaging and Queuing
3737

@@ -76,7 +76,7 @@ A subscription protocol refers to the communication method used to deliver messa
7676

7777
## Topic
7878

79-
A topic is a communication channel used to send messages and notifications to subscribed endpoints or clients. Publishers send messages to topics, and those messages are received by subscribers. Subscribers can include Serverless Functions, Scaleway Queues and HTTP/HTTPS endpoints. As such, topics decouple the publishing and the receiving of messages, allowing for flexibility and scalabilty in building loosely-coupled systems.
79+
A topic is a communication channel used to send messages and notifications to subscribed endpoints or clients. Publishers send messages to topics, and those messages are received by subscribers. Subscribers can include Serverless Functions, Scaleway Queues and HTTP/HTTPS endpoints. As such, topics decouple the publishing and the receiving of messages, allowing for flexibility and scalability in building loosely-coupled systems.
8080

8181
## Topic types
8282

pages/topics-and-events/how-to/create-credentials.mdx

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,3 @@ Credentials for Topics and Events are granular: you can define the level of acce
4747
8. Copy and save the credentials, before closing the window.
4848

4949
You are returned to the **Credentials** tab. The name of your newly-generated credentials, along with the access key and access level are displayed.
50-
51-
52-
53-
54-

pages/topics-and-events/how-to/create-manage-subscriptions.mdx

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ This page shows how to create and manage [subscriptions](/topics-and-events/conc
6262

6363
You are prompted to select the **namespace** containing the Function or Container that you want to subscribe. Only namespaces in the same [Project](/organizations-and-projects/concepts/#project) and [region](/topics-and-events/concepts/#region) as the topic can be selected.
6464

65-
You are prompted to select the Serverless Function or Container to subscribe. Only Functions and Containers with a public [privacy policy](/serverless-functions/concepts/#privacy-policy) can subscribe to an topic.
65+
You are prompted to select the Serverless Function or Container to subscribe. Only Functions and Containers with a public [privacy policy](/serverless-functions/concepts/#privacy-policy) can subscribe to a topic.
6666
</TabsTab>
6767
<TabsTab label="Queues">
6868
<br />
@@ -113,5 +113,3 @@ When you no longer want a subscribed endpoint or service to receive messages fro
113113
A pop-up asks you to confirm that you understand this action will delete the subscription.
114114

115115
6. Type **DELETE** and click **Delete subscription**.
116-
117-

0 commit comments

Comments
 (0)