You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
- Create a topic branch from where you want to base your work (usually master)
53
53
- Add tests to cover contributed code
54
54
- Push your commit(s) to your topic branch on your fork
55
-
- Open a pull request against `scaleway-cli``v2` branch that follows [PR guidelines](#pull-request-guidelines)
55
+
- Open a pull request against `scaleway-cli``master` branch that follows [PR guidelines](#pull-request-guidelines)
56
56
57
57
The [maintainers](MAINTAINERS.md) of `scaleway-cli` use a "Let's Get This Merged" (LGTM) message in the pull request to note that the commits are ready to merge.
58
58
After one or more maintainer states LGTM, we will merge.
@@ -73,9 +73,7 @@ The goal of the following guidelines is to have Pull Requests (PRs) that are fai
73
73
-**Please, keep us updated.**
74
74
We will try our best to merge your PR, but please notice that PRs may be closed after 30 days of inactivity.
75
75
76
-
Your pull request should be rebased against the current `v2` branch. Please do not merge
77
-
the current `v2` branch in with your topic branch, nor use the Update Branch button provided
78
-
by GitHub on the pull request page.
76
+
Your pull request should be rebased against the `master` branch.
79
77
80
78
Keep in mind only the **pull request title** will be used as commit message as we stash all commits on merge.
0 commit comments