Skip to content

Commit 0dfc9ef

Browse files
remyleonescaleway-botMonitob
authored
feat(rdb): add support for PrivateNetwork and LoadBalancer in Endpoint (#1960)
* feat(rdb): add support for PrivateNetwork and LoadBalancer in Endpoint * Fix Co-authored-by: scaleway-bot <[email protected]> Co-authored-by: jaime Bernabe <[email protected]>
1 parent 8d857be commit 0dfc9ef

File tree

3 files changed

+31
-15
lines changed

3 files changed

+31
-15
lines changed

cmd/scw/testdata/test-all-usage-rdb-instance-create-usage.golden

Lines changed: 17 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -6,21 +6,23 @@ USAGE:
66
scw rdb instance create [arg=value ...]
77

88
ARGS:
9-
[project-id] Project ID to use. If none is passed the default project ID will be used
10-
[name=<generated>] Name of the instance
11-
engine Database engine of the database (PostgreSQL, MySQL, ...)
12-
user-name Name of the user created when the instance is created
13-
password Password of the user
14-
node-type=DB-DEV-S Type of node to use for the instance (DB-DEV-S | DB-DEV-M | DB-DEV-L | DB-DEV-XL | DB-GP-XS | DB-GP-S | DB-GP-M | DB-GP-L | DB-GP-XL)
15-
[is-ha-cluster] Whether or not High-Availability is enabled
16-
[disable-backup] Whether or not backups are disabled
17-
[tags.{index}] Tags to apply to the instance
18-
[init-settings.{index}.name]
19-
[init-settings.{index}.value]
20-
[volume-type] Type of volume where data are stored (lssd, bssd, ...) (lssd | bssd)
21-
[volume-size] Volume size when volume_type is not lssd
22-
[organization-id] Organization ID to use. If none is passed the default organization ID will be used
23-
[region=fr-par] Region to target. If none is passed will use default region from the config (fr-par | nl-ams | pl-waw)
9+
[project-id] Project ID to use. If none is passed the default project ID will be used
10+
[name=<generated>] Name of the instance
11+
engine Database engine of the database (PostgreSQL, MySQL, ...)
12+
user-name Name of the user created when the instance is created
13+
password Password of the user
14+
node-type=DB-DEV-S Type of node to use for the instance (DB-DEV-S | DB-DEV-M | DB-DEV-L | DB-DEV-XL | DB-GP-XS | DB-GP-S | DB-GP-M | DB-GP-L | DB-GP-XL)
15+
[is-ha-cluster] Whether or not High-Availability is enabled
16+
[disable-backup] Whether or not backups are disabled
17+
[tags.{index}] Tags to apply to the instance
18+
[init-settings.{index}.name]
19+
[init-settings.{index}.value]
20+
[volume-type] Type of volume where data are stored (lssd, bssd, ...) (lssd | bssd)
21+
[volume-size] Volume size when volume_type is not lssd
22+
[init-endpoints.{index}.private-network.private-network-id]
23+
[init-endpoints.{index}.private-network.service-ip]
24+
[organization-id] Organization ID to use. If none is passed the default organization ID will be used
25+
[region=fr-par] Region to target. If none is passed will use default region from the config (fr-par | nl-ams | pl-waw)
2426

2527
FLAGS:
2628
-h, --help help for create

docs/commands/rdb.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -519,6 +519,8 @@ scw rdb instance create [arg=value ...]
519519
| init-settings.{index}.value | | |
520520
| volume-type | One of: `lssd`, `bssd` | Type of volume where data are stored (lssd, bssd, ...) |
521521
| volume-size | | Volume size when volume_type is not lssd |
522+
| init-endpoints.{index}.private-network.private-network-id | | |
523+
| init-endpoints.{index}.private-network.service-ip | | |
522524
| organization-id | | Organization ID to use. If none is passed the default organization ID will be used |
523525
| region | Default: `fr-par`<br />One of: `fr-par`, `nl-ams`, `pl-waw` | Region to target. If none is passed will use default region from the config |
524526

internal/namespaces/rdb/v1/rdb_cli.go

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -810,6 +810,18 @@ func rdbInstanceCreate() *core.Command {
810810
Deprecated: false,
811811
Positional: false,
812812
},
813+
{
814+
Name: "init-endpoints.{index}.private-network.private-network-id",
815+
Required: false,
816+
Deprecated: false,
817+
Positional: false,
818+
},
819+
{
820+
Name: "init-endpoints.{index}.private-network.service-ip",
821+
Required: false,
822+
Deprecated: false,
823+
Positional: false,
824+
},
813825
core.OrganizationIDArgSpec(),
814826
core.RegionArgSpec(scw.RegionFrPar, scw.RegionNlAms, scw.RegionPlWaw),
815827
},

0 commit comments

Comments
 (0)