Skip to content

Commit 13c1730

Browse files
scaleway-botyfodilCodelax
authored
fix(container/function): remove deprecated mnq namespace fields (#3690)
Co-authored-by: Yacine Fodil <[email protected]> Co-authored-by: Jules Castéran <[email protected]>
1 parent 44faa12 commit 13c1730

File tree

6 files changed

+0
-36
lines changed

6 files changed

+0
-36
lines changed

cmd/scw/testdata/test-all-usage-container-trigger-create-usage.golden

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,6 @@ ARGS:
1818
[scw-nats-config.mnq-region] Region in which the Messaging and Queuing project is activated.
1919
[region=fr-par] Region to target. If none is passed will use default region from the config (fr-par | nl-ams | pl-waw)
2020

21-
DEPRECATED ARGS:
22-
[scw-sqs-config.mnq-namespace-id]
23-
[scw-nats-config.mnq-namespace-id]
24-
2521
FLAGS:
2622
-h, --help help for create
2723

cmd/scw/testdata/test-all-usage-function-trigger-create-usage.golden

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,6 @@ ARGS:
1818
[scw-nats-config.mnq-region] Region in which the Messaging and Queuing project is activated.
1919
[region=fr-par] Region to target. If none is passed will use default region from the config (fr-par | nl-ams | pl-waw)
2020

21-
DEPRECATED ARGS:
22-
[scw-sqs-config.mnq-namespace-id]
23-
[scw-nats-config.mnq-namespace-id]
24-
2521
FLAGS:
2622
-h, --help help for create
2723

docs/commands/container.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -684,11 +684,9 @@ scw container trigger create [arg=value ...]
684684
| name | Required | Name of the trigger |
685685
| container-id | Required | ID of the container to trigger |
686686
| description | | Description of the trigger |
687-
| ~~scw-sqs-config.mnq-namespace-id~~ | Deprecated | |
688687
| scw-sqs-config.queue | | Name of the SQS queue the trigger should listen to |
689688
| scw-sqs-config.mnq-project-id | | ID of the Messaging and Queuing project |
690689
| scw-sqs-config.mnq-region | | Region in which the Messaging and Queuing project is activated. |
691-
| ~~scw-nats-config.mnq-namespace-id~~ | Deprecated | |
692690
| scw-nats-config.subject | | Name of the NATS subject the trigger should listen to |
693691
| scw-nats-config.mnq-nats-account-id | | ID of the Messaging and Queuing NATS account |
694692
| scw-nats-config.mnq-project-id | | ID of the Messaging and Queuing project |

docs/commands/function.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -741,11 +741,9 @@ scw function trigger create [arg=value ...]
741741
| name | Required | Name of the trigger |
742742
| function-id | Required | ID of the function to trigger |
743743
| description | | Description of the trigger |
744-
| ~~scw-sqs-config.mnq-namespace-id~~ | Deprecated | |
745744
| scw-sqs-config.queue | | Name of the SQS queue the trigger should listen to |
746745
| scw-sqs-config.mnq-project-id | | ID of the Messaging and Queuing project |
747746
| scw-sqs-config.mnq-region | | Region in which the Messaging and Queuing project is activated. |
748-
| ~~scw-nats-config.mnq-namespace-id~~ | Deprecated | |
749747
| scw-nats-config.subject | | Name of the NATS subject the trigger should listen to |
750748
| scw-nats-config.mnq-nats-account-id | | ID of the Messaging and Queuing NATS account |
751749
| scw-nats-config.mnq-project-id | | ID of the Messaging and Queuing project |

internal/namespaces/container/v1beta1/container_cli.go

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1402,12 +1402,6 @@ func containerTriggerCreate() *core.Command {
14021402
Deprecated: false,
14031403
Positional: false,
14041404
},
1405-
{
1406-
Name: "scw-sqs-config.mnq-namespace-id",
1407-
Required: false,
1408-
Deprecated: true,
1409-
Positional: false,
1410-
},
14111405
{
14121406
Name: "scw-sqs-config.queue",
14131407
Short: `Name of the SQS queue the trigger should listen to`,
@@ -1429,12 +1423,6 @@ func containerTriggerCreate() *core.Command {
14291423
Deprecated: false,
14301424
Positional: false,
14311425
},
1432-
{
1433-
Name: "scw-nats-config.mnq-namespace-id",
1434-
Required: false,
1435-
Deprecated: true,
1436-
Positional: false,
1437-
},
14381426
{
14391427
Name: "scw-nats-config.subject",
14401428
Short: `Name of the NATS subject the trigger should listen to`,

internal/namespaces/function/v1beta1/function_cli.go

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1500,12 +1500,6 @@ func functionTriggerCreate() *core.Command {
15001500
Deprecated: false,
15011501
Positional: false,
15021502
},
1503-
{
1504-
Name: "scw-sqs-config.mnq-namespace-id",
1505-
Required: false,
1506-
Deprecated: true,
1507-
Positional: false,
1508-
},
15091503
{
15101504
Name: "scw-sqs-config.queue",
15111505
Short: `Name of the SQS queue the trigger should listen to`,
@@ -1527,12 +1521,6 @@ func functionTriggerCreate() *core.Command {
15271521
Deprecated: false,
15281522
Positional: false,
15291523
},
1530-
{
1531-
Name: "scw-nats-config.mnq-namespace-id",
1532-
Required: false,
1533-
Deprecated: true,
1534-
Positional: false,
1535-
},
15361524
{
15371525
Name: "scw-nats-config.subject",
15381526
Short: `Name of the NATS subject the trigger should listen to`,

0 commit comments

Comments
 (0)