Skip to content

Commit 1870deb

Browse files
fix(telemetry): disable telemetry on completion (#684)
1 parent a036120 commit 1870deb

File tree

2 files changed

+20
-17
lines changed

2 files changed

+20
-17
lines changed

internal/core/build_info_test.go

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,8 @@ import (
1212
)
1313

1414
var fakeCommand = &Command{
15-
Namespace: "plop",
16-
DisableTelemetry: true,
17-
ArgsType: reflect.TypeOf(args.RawArgs{}),
15+
Namespace: "plop",
16+
ArgsType: reflect.TypeOf(args.RawArgs{}),
1817
Run: func(ctx context.Context, argsI interface{}) (i interface{}, e error) {
1918
return &SuccessResult{}, nil
2019
},

internal/namespaces/autocomplete/autocomplete.go

Lines changed: 18 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -236,9 +236,10 @@ func autocompleteCompleteBashCommand() *core.Command {
236236
Resource: "complete",
237237
Verb: "bash",
238238
// TODO: Switch NoClient to true when cache will be implemented.
239-
NoClient: false,
240-
Hidden: true,
241-
ArgsType: reflect.TypeOf(args.RawArgs{}),
239+
NoClient: false,
240+
Hidden: true,
241+
DisableTelemetry: true,
242+
ArgsType: reflect.TypeOf(args.RawArgs{}),
242243
Run: func(ctx context.Context, argsI interface{}) (i interface{}, e error) {
243244
rawArgs := *argsI.(*args.RawArgs)
244245
wordIndex, err := strconv.Atoi(rawArgs[1])
@@ -273,9 +274,10 @@ func autocompleteCompleteFishCommand() *core.Command {
273274
Resource: "complete",
274275
Verb: "fish",
275276
// TODO: Switch NoClient to true when cache will be implemented.
276-
NoClient: false,
277-
Hidden: true,
278-
ArgsType: reflect.TypeOf(args.RawArgs{}),
277+
NoClient: false,
278+
Hidden: true,
279+
DisableTelemetry: true,
280+
ArgsType: reflect.TypeOf(args.RawArgs{}),
279281
Run: func(ctx context.Context, argsI interface{}) (i interface{}, e error) {
280282
rawArgs := *argsI.(*args.RawArgs)
281283
leftWords := rawArgs[3:]
@@ -304,9 +306,10 @@ func autocompleteCompleteZshCommand() *core.Command {
304306
Resource: "complete",
305307
Verb: "zsh",
306308
// TODO: Switch NoClient to true when cache will be implemented.
307-
NoClient: false,
308-
Hidden: true,
309-
ArgsType: reflect.TypeOf(args.RawArgs{}),
309+
NoClient: false,
310+
Hidden: true,
311+
DisableTelemetry: true,
312+
ArgsType: reflect.TypeOf(args.RawArgs{}),
310313
Run: func(ctx context.Context, argsI interface{}) (i interface{}, e error) {
311314
rawArgs := *argsI.(*args.RawArgs)
312315

@@ -343,11 +346,12 @@ type autocompleteShowArgs struct {
343346

344347
func autocompleteScriptCommand() *core.Command {
345348
return &core.Command{
346-
Short: `Show autocomplete script for current shell`,
347-
Long: `Show autocomplete script for current shell.`,
348-
Namespace: "autocomplete",
349-
Resource: "script",
350-
NoClient: true,
349+
Short: `Show autocomplete script for current shell`,
350+
Long: `Show autocomplete script for current shell.`,
351+
Namespace: "autocomplete",
352+
Resource: "script",
353+
NoClient: true,
354+
DisableTelemetry: true,
351355
ArgSpecs: core.ArgSpecs{
352356
{
353357
Name: "shell",

0 commit comments

Comments
 (0)