fix(core): do not require a config file if required env vars are set (#2550)

Author: jawher

internal/core/client.go

@@ -2,6 +2,7 @@ package core
 
 import (
 	"context"
+	"errors"
 	"fmt"
 	"net/http"
 	"strings"
@@ -13,30 +14,36 @@ import (
 
 // createClient creates a Scaleway SDK client.
 func createClient(ctx context.Context, httpClient *http.Client, buildInfo *BuildInfo, profileName string) (*scw.Client, error) {
-	_, err := scw.MigrateLegacyConfig()
-	if err != nil {
+	if _, err := scw.MigrateLegacyConfig(); err != nil {
 		return nil, err
 	}
 
+	profile := scw.LoadEnvProfile()
+
 	// Default path is based on the following priority order:
 	// * The config file's path provided via --config flag
 	// * $SCW_CONFIG_PATH
 	// * $XDG_CONFIG_HOME/scw/config.yaml
 	// * $HOME/.config/scw/config.yaml
 	// * $USERPROFILE/.config/scw/config.yaml
 	config, err := scw.LoadConfigFromPath(ExtractConfigPath(ctx))
-	if err != nil {
-		return nil, err
-	}
+	switch {
+	case errIsConfigFileNotFound(err):
+		// no config file was found -> nop
 
-	activeProfile, err := config.GetProfile(profileName)
-	if err != nil {
+	case err != nil:
+		// failed to read the config file -> fail
 		return nil, err
-	}
 
-	envProfile := scw.LoadEnvProfile()
+	default:
+		// found and loaded a config file -> merge with env
+		activeProfile, err := config.GetProfile(profileName)
+		if err != nil {
+			return nil, err
+		}
 
-	profile := scw.MergeProfiles(activeProfile, envProfile)
+		profile = scw.MergeProfiles(activeProfile, profile)
+	}
 
 	// If profile have a defaultZone but no defaultRegion we set the defaultRegion
 	// to the one of the defaultZone
@@ -199,3 +206,8 @@ func validateClient(client *scw.Client) error {
 
 	return nil
 }
+
+func errIsConfigFileNotFound(err error) bool {
+	var target *scw.ConfigFileNotFoundError
+	return errors.As(err, &target)
+}