doc(instance): remove outdated TODOs in create_server (#1466)

Quentin Brosse · web-flow · commit 28af2f121f7c · 2020-10-08T16:53:43.000+02:00
diff --git a/internal/namespaces/instance/v1/custom_server_create.go b/internal/namespaces/instance/v1/custom_server_create.go
@@ -18,7 +18,6 @@ import (
 	"github.com/scaleway/scaleway-sdk-go/validation"
 )
 
-// TODO: Add cloud-init
 type instanceCreateServerRequest struct {
 	Zone              scw.Zone
 	ProjectID         *string
@@ -41,7 +40,6 @@ type instanceCreateServerRequest struct {
 	OrganizationID *string
 }
 
-// TODO: Remove all error uppercase and punctuations when [APIGW-1367] will be done
 func serverCreateCommand() *core.Command {
 	return &core.Command{
 		Short:     `Create server`,
@@ -473,7 +471,7 @@ func buildVolumeTemplate(api *instance.API, zone scw.Zone, flagV string) (*insta
 
 		size, err := humanize.ParseBytes(parts[1])
 		if err != nil {
-			return nil, fmt.Errorf("invalid size format %s in %s volume", parts[1], flagV) // TODO: improve msg [APIGW-1371]
+			return nil, fmt.Errorf("invalid size format %s in %s volume", parts[1], flagV)
 		}
 		vt.Size = scw.Size(size)
 

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,6 @@ import (`
`18`	`18`	`"github.com/scaleway/scaleway-sdk-go/validation"`
`19`	`19`	`)`
`20`	`20`
`21`		`-// TODO: Add cloud-init`
`22`	`21`	`type instanceCreateServerRequest struct {`
`23`	`22`	`Zone scw.Zone`
`24`	`23`	`ProjectID *string`
`@@ -41,7 +40,6 @@ type instanceCreateServerRequest struct {`
`41`	`40`	`OrganizationID *string`
`42`	`41`	`}`
`43`	`42`
`44`		`-// TODO: Remove all error uppercase and punctuations when [APIGW-1367] will be done`
`45`	`43`	`func serverCreateCommand() *core.Command {`
`46`	`44`	`return &core.Command{`
`47`	`45`	Short: `Create server`,
`@@ -473,7 +471,7 @@ func buildVolumeTemplate(api instance.API, zone scw.Zone, flagV string) (insta`
`473`	`471`
`474`	`472`	`size, err := humanize.ParseBytes(parts[1])`
`475`	`473`	`if err != nil {`
`476`		`- return nil, fmt.Errorf("invalid size format %s in %s volume", parts[1], flagV) // TODO: improve msg [APIGW-1371]`
	`474`	`+ return nil, fmt.Errorf("invalid size format %s in %s volume", parts[1], flagV)`
`477`	`475`	`}`
`478`	`476`	`vt.Size = scw.Size(size)`
`479`	`477`