feat(vpc_gw.v1): document behavior of non-ipam_config flags (#3364)

Author: scaleway-bot

cmd/scw/testdata/test-all-usage-vpc-gw-gateway-network-create-usage.golden

@@ -8,8 +8,8 @@ USAGE:
 ARGS:
   [gateway-id]                       Public Gateway to connect
   [private-network-id]               Private Network to connect
-  [enable-masquerade]                Defines whether to enable masquerade (dynamic NAT) on this network
-  [enable-dhcp]                      Defines whether to enable DHCP on this Private Network. Defaults to `true` if either `dhcp_id` or `dhcp` are present. If set to `true`, either `dhcp_id` or `dhcp` must be present
+  [enable-masquerade]                Defines whether to enable masquerade (dynamic NAT) on the GatewayNetwork.
+  [enable-dhcp]                      Defines whether to enable DHCP on this Private Network.
   [dhcp-id]                          ID of an existing DHCP configuration object to use for this GatewayNetwork
   [address]                          Static IP address in CIDR format to to use without DHCP
   [ipam-config.push-default-route]   Defines whether the default route is enabled on that Gateway Network.

cmd/scw/testdata/test-all-usage-vpc-gw-gateway-network-update-usage.golden

@@ -7,8 +7,8 @@ USAGE:
 
 ARGS:
   gateway-network-id                 ID of the GatewayNetwork to update
-  [enable-masquerade]                Defines whether to enable masquerade (dynamic NAT) on the GatewayNetwork
-  [enable-dhcp]                      Defines whether to enable DHCP on the connected Private Network
+  [enable-masquerade]                Defines whether to enable masquerade (dynamic NAT) on the GatewayNetwork.
+  [enable-dhcp]                      Defines whether to enable DHCP on this Private Network.
   [dhcp-id]                          ID of the new DHCP configuration object to use with this GatewayNetwork
   [address]                          New static IP address
   [ipam-config.push-default-route]   Defines whether the default route is enabled on that Gateway Network.

docs/commands/vpc-gw.md

@@ -515,8 +515,8 @@ scw vpc-gw gateway-network create [arg=value ...]
 |------|---|-------------|
 | gateway-id |  | Public Gateway to connect |
 | private-network-id |  | Private Network to connect |
-| enable-masquerade |  | Defines whether to enable masquerade (dynamic NAT) on this network |
-| enable-dhcp |  | Defines whether to enable DHCP on this Private Network. Defaults to `true` if either `dhcp_id` or `dhcp` are present. If set to `true`, either `dhcp_id` or `dhcp` must be present |
+| enable-masquerade |  | Defines whether to enable masquerade (dynamic NAT) on the GatewayNetwork. |
+| enable-dhcp |  | Defines whether to enable DHCP on this Private Network. |
 | dhcp-id |  | ID of an existing DHCP configuration object to use for this GatewayNetwork |
 | address |  | Static IP address in CIDR format to to use without DHCP |
 | ipam-config.push-default-route |  | Defines whether the default route is enabled on that Gateway Network. |
@@ -606,8 +606,8 @@ scw vpc-gw gateway-network update <gateway-network-id ...> [arg=value ...]
 | Name |   | Description |
 |------|---|-------------|
 | gateway-network-id | Required | ID of the GatewayNetwork to update |
-| enable-masquerade |  | Defines whether to enable masquerade (dynamic NAT) on the GatewayNetwork |
-| enable-dhcp |  | Defines whether to enable DHCP on the connected Private Network |
+| enable-masquerade |  | Defines whether to enable masquerade (dynamic NAT) on the GatewayNetwork. |
+| enable-dhcp |  | Defines whether to enable DHCP on this Private Network. |
 | dhcp-id |  | ID of the new DHCP configuration object to use with this GatewayNetwork |
 | address |  | New static IP address |
 | ipam-config.push-default-route |  | Defines whether the default route is enabled on that Gateway Network. |

internal/namespaces/vpcgw/v1/vpcgw_cli.go

@@ -691,14 +691,14 @@ func vpcGwGatewayNetworkCreate() *core.Command {
 			},
 			{
 				Name:       "enable-masquerade",
-				Short:      `Defines whether to enable masquerade (dynamic NAT) on this network`,
+				Short:      `Defines whether to enable masquerade (dynamic NAT) on the GatewayNetwork.`,
 				Required:   false,
 				Deprecated: false,
 				Positional: false,
 			},
 			{
 				Name:       "enable-dhcp",
-				Short:      `Defines whether to enable DHCP on this Private Network. Defaults to ` + "`" + `true` + "`" + ` if either ` + "`" + `dhcp_id` + "`" + ` or ` + "`" + `dhcp` + "`" + ` are present. If set to ` + "`" + `true` + "`" + `, either ` + "`" + `dhcp_id` + "`" + ` or ` + "`" + `dhcp` + "`" + ` must be present`,
+				Short:      `Defines whether to enable DHCP on this Private Network.`,
 				Required:   false,
 				Deprecated: false,
 				Positional: false,
@@ -756,14 +756,14 @@ func vpcGwGatewayNetworkUpdate() *core.Command {
 			},
 			{
 				Name:       "enable-masquerade",
-				Short:      `Defines whether to enable masquerade (dynamic NAT) on the GatewayNetwork`,
+				Short:      `Defines whether to enable masquerade (dynamic NAT) on the GatewayNetwork.`,
 				Required:   false,
 				Deprecated: false,
 				Positional: false,
 			},
 			{
 				Name:       "enable-dhcp",
-				Short:      `Defines whether to enable DHCP on the connected Private Network`,
+				Short:      `Defines whether to enable DHCP on this Private Network.`,
 				Required:   false,
 				Deprecated: false,
 				Positional: false,