Golint fixes

Author: moul

Makefile

@@ -85,3 +85,8 @@ travis_install:
 
 travis_run: build
 	go test -v -covermode=count -coverprofile=profile.cov
+
+
+golint:
+	@go get github.com/golang/lint/golint
+	@for dir in */; do golint $$dir; done

api/api.go

@@ -452,6 +452,7 @@ type ScalewayImageDefinition struct {
 	Arch               string `json:"arch"`
 }
 
+// FuncMap used for json inspection
 var FuncMap = template.FuncMap{
 	"json": func(v interface{}) string {
 		a, _ := json.Marshal(v)

api/helpers.go

@@ -199,6 +199,7 @@ func InspectIdentifiers(api *ScalewayAPI, ci chan ScalewayResolvedIdentifier, cj
 	close(cj)
 }
 
+// CreateServer creates a server using API based on typical server fields
 func CreateServer(api *ScalewayAPI, imageName string, name string, bootscript string, env string, additionalVolumes string) (string, error) {
 	if name == "" {
 		name = strings.Replace(namesgenerator.GetRandomName(0), "_", "-", -1)
@@ -295,6 +296,7 @@ func (a ByCreationDate) Len() int           { return len(a) }
 func (a ByCreationDate) Swap(i, j int)      { a[i], a[j] = a[j], a[i] }
 func (a ByCreationDate) Less(i, j int) bool { return a[j].CreationDate.Before(a[i].CreationDate) }
 
+// StartServer start a server based on its needle, can optionaly block while server is booting
 func StartServer(api *ScalewayAPI, needle string, wait bool) error {
 	server := api.GetServerID(needle)
 
@@ -314,6 +316,7 @@ func StartServer(api *ScalewayAPI, needle string, wait bool) error {
 	return nil
 }
 
+// StartServerOnce wraps StartServer for golang channel
 func StartServerOnce(api *ScalewayAPI, needle string, wait bool, successChan chan bool, errChan chan error) {
 	err := StartServer(api, needle, wait)
 

commands/commands.go

@@ -2,6 +2,7 @@ package commands
 
 import types "github.com/scaleway/scaleway-cli/commands/types"
 
+// Commands is the list of enabled CLI commands
 var Commands = []*types.Command{
 	CmdHelp,
 

commands/cp.go

@@ -44,6 +44,7 @@ func init() {
 // Flags
 var cpHelp bool // -h, --help flag
 
+// TarFromSource creates a stream buffer with the tarballed content of the user source
 func TarFromSource(api *api.ScalewayAPI, source string) (*io.ReadCloser, error) {
 	var tarOutputStream io.ReadCloser
 
@@ -132,6 +133,7 @@ func TarFromSource(api *api.ScalewayAPI, source string) (*io.ReadCloser, error)
 	return &tarOutputStream, nil
 }
 
+// UntarToDest writes to user destination the streamed tarball in input
 func UntarToDest(api *api.ScalewayAPI, sourceStream *io.ReadCloser, destination string) error {
 	// destination is a server address + path (scp-like uri)
 	if strings.Index(destination, ":") > -1 {

commands/exec.go

@@ -72,7 +72,7 @@ func runExec(cmd *types.Command, args []string) {
 		}()
 	}
 
-	err = utils.SshExec(server.PublicAddress.IP, args[1:], !execW)
+	err = utils.SSHExec(server.PublicAddress.IP, args[1:], !execW)
 	if err != nil {
 		log.Fatalf("%v", err)
 		os.Exit(1)

commands/help.go

@@ -8,6 +8,7 @@ import (
 	types "github.com/scaleway/scaleway-cli/commands/types"
 )
 
+// CmdHelp is the 'scw help' command
 var CmdHelp = &types.Command{
 	Exec:        nil,
 	UsageLine:   "help [COMMAND]",

commands/logs.go

@@ -38,7 +38,7 @@ func runLogs(cmd *types.Command, args []string) {
 	// FIXME: switch to serial history when API is ready
 
 	command := []string{"dmesg"}
-	err = utils.SshExec(server.PublicAddress.IP, command, true)
+	err = utils.SSHExec(server.PublicAddress.IP, command, true)
 	if err != nil {
 		log.Fatalf("Command execution failed: %v", err)
 	}

commands/port.go

@@ -36,7 +36,7 @@ func runPort(cmd *types.Command, args []string) {
 	}
 
 	command := []string{"netstat -lutn 2>/dev/null | grep LISTEN"}
-	err = utils.SshExec(server.PublicAddress.IP, command, true)
+	err = utils.SSHExec(server.PublicAddress.IP, command, true)
 	if err != nil {
 		log.Fatalf("Command execution failed: %v", err)
 	}

commands/run.go

@@ -75,9 +75,9 @@ func runRun(cmd *types.Command, args []string) {
 	// exec -w SERVER COMMAND ARGS...
 	log.Debugf("Executing command")
 	if len(args) < 2 {
-		err = utils.SshExec(server.PublicAddress.IP, []string{"if [ -x /bin/bash ]; then /bin/bash; else /bin/sh; fi"}, false)
+		err = utils.SSHExec(server.PublicAddress.IP, []string{"if [ -x /bin/bash ]; then /bin/bash; else /bin/sh; fi"}, false)
 	} else {
-		err = utils.SshExec(server.PublicAddress.IP, args[1:], false)
+		err = utils.SSHExec(server.PublicAddress.IP, args[1:], false)
 	}
 	if err != nil {
 		log.Debugf("Command execution failed: %v", err)