chore: add support for wastedassign (#4062)

Author: remyleone

.golangci.yml

@@ -53,6 +53,7 @@ linters:
     - unparam # Reports unused function parameters [fast: false, auto-fix: false]
     - unused #(megacheck): Checks Go code for unused constants, variables, functions and types [fast: false, auto-fix: false]
     - usestdlibvars # A linter that detect the possibility to use variables/constants from the Go standard library. [fast: true, auto-fix: false]
+    - wastedassign # wastedassign finds wasted assignment statements. [fast: false, auto-fix: false]
     - whitespace # Tool for detection of leading and trailing whitespace [fast: true, auto-fix: true]
     - zerologlint # Detects the wrong usage of `zerolog` that a user forgets to dispatch with `Send` or `Msg` [fast: false, auto-fix: false]
 

internal/human/marshal.go

@@ -318,7 +318,7 @@ func marshalSlice(slice reflect.Value, opt *MarshalOpt) (string, error) {
 			}
 			fieldValue := reflect.ValueOf(v)
 
-			str := ""
+			var str string
 			switch {
 			// Handle inline slice.
 			case fieldValue.Type().Kind() == reflect.Slice:

internal/interactive/prompt.go

@@ -145,7 +145,7 @@ func Readline(config *ReadlineConfig) (string, error) {
 	}
 
 	promptHandler = &ReadlineHandler{rl: rl}
-	s := ""
+	var s string
 	for {
 		s, err = rl.Readline()
 		// If readline returns an error we return it

internal/namespaces/object/v1/s3_helpers.go

@@ -24,7 +24,7 @@ func newS3Client(ctx context.Context, region scw.Region) *s3.Client {
 		return nil
 	}
 
-	customEndpoint := ""
+	var customEndpoint string
 	if ep := os.Getenv("SCW_S3_ENDPOINT"); ep != "" {
 		customEndpoint = ep
 	} else {

internal/namespaces/rdb/v1/custom_acl.go

@@ -196,7 +196,7 @@ func aclDeleteBuilder(c *core.Command) *core.Command {
 			return nil, fmt.Errorf("failed to remove ACL rule: %w", err)
 		}
 
-		message := ""
+		var message string
 		if ruleWasSet {
 			message = fmt.Sprintf("ACL rule %s successfully deleted", args.ACLRuleIPs.String())
 		} else {

internal/namespaces/rdb/v1/custom_instance.go

@@ -652,7 +652,7 @@ Learn more at: https://dev.mysql.com/doc/refman/8.0/en/option-files.html`
 )
 
 func passwordFileExist(ctx context.Context, family engineFamily) bool {
-	passwordFilePath := ""
+	var passwordFilePath string
 	switch family {
 	case PostgreSQL:
 		switch runtime.GOOS {

internal/qa/ignore.go

@@ -19,7 +19,7 @@ func filterIgnore(unfilteredErrors []error) []error {
 
 func isIgnoredError(err error) bool {
 	for _, ignoredError := range ignoredErrors {
-		isEqual := false
+		var isEqual bool
 		switch typedError := err.(type) {
 		case *DifferentLocalizationForNamespaceError:
 			isEqual = areCommandsEquals(typedError.Command1, ignoredError.Command) || areCommandsEquals(typedError.Command2, ignoredError.Command)