core: add parsing for absolute time.Time (#1210)

Author: remyleone

internal/args/args_test.go

@@ -5,6 +5,7 @@ import (
 	"reflect"
 	"strings"
 	"testing"
+	"time"
 
 	"github.com/alecthomas/assert"
 	"github.com/scaleway/scaleway-sdk-go/scw"
@@ -35,6 +36,7 @@ type Slice struct {
 
 type WellKnownTypes struct {
 	Size scw.Size
+	Time time.Time
 }
 
 type Nested struct {

internal/args/marshal.go

@@ -10,6 +10,7 @@ import (
 	"sort"
 	"strconv"
 	"strings"
+	"time"
 
 	"github.com/dustin/go-humanize"
 	"github.com/scaleway/scaleway-sdk-go/scw"
@@ -29,6 +30,10 @@ var marshalFuncs = map[reflect.Type]MarshalFunc{
 		value = strings.Replace(value, " ", "", -1)
 		return value, nil
 	},
+	reflect.TypeOf((*time.Time)(nil)).Elem(): func(src interface{}) (string, error) {
+		v := src.(*time.Time)
+		return v.Format(time.RFC3339), nil
+	},
 }
 
 // MarshalStruct marshals a go struct using reflection to args like ["arg1=1", "arg2=2"].

internal/args/marshal_test.go

@@ -2,6 +2,7 @@ package args
 
 import (
 	"testing"
+	"time"
 
 	"github.com/scaleway/scaleway-sdk-go/scw"
 	"github.com/stretchr/testify/assert"
@@ -120,9 +121,11 @@ func TestMarshal(t *testing.T) {
 	t.Run("well-known-types", run(TestCase{
 		data: &WellKnownTypes{
 			Size: 20 * scw.GB,
+			Time: time.Date(2006, 01, 02, 15, 04, 05, 0, time.UTC),
 		},
 		expected: []string{
 			"size=20GB",
+			"time=2006-01-02T15:04:05Z",
 		},
 	}))
 

internal/args/unmarshal.go

@@ -10,6 +10,7 @@ import (
 	"reflect"
 	"strconv"
 	"strings"
+	"time"
 
 	"github.com/dustin/go-humanize"
 	"github.com/scaleway/scaleway-sdk-go/scw"
@@ -45,6 +46,16 @@ var unmarshalFuncs = map[reflect.Type]UnmarshalFunc{
 		*(dest.(*io.Reader)) = strings.NewReader(value)
 		return nil
 	},
+	reflect.TypeOf((*time.Time)(nil)).Elem(): func(value string, dest interface{}) error {
+		// Handle absolute time
+		t, err := time.Parse(time.RFC3339, value)
+		if err != nil {
+			return err
+		}
+
+		*(dest.(*time.Time)) = t
+		return nil
+	},
 }
 
 // UnmarshalStruct parses args like ["arg1=1", "arg2=2"] to a Go structure using reflection.

internal/args/unmarshal_test.go

@@ -3,6 +3,7 @@ package args
 import (
 	"reflect"
 	"testing"
+	"time"
 
 	"github.com/scaleway/scaleway-sdk-go/scw"
 	"github.com/stretchr/testify/assert"
@@ -236,6 +237,15 @@ func TestUnmarshalStruct(t *testing.T) {
 		},
 	}))
 
+	t.Run("Absolute date", run(TestCase{
+		args: []string{
+			"time=2006-01-02T15:04:05Z",
+		},
+		expected: &WellKnownTypes{
+			Time: time.Date(2006, 01, 02, 15, 04, 05, 0, time.UTC),
+		},
+	}))
+
 	t.Run("nested-basic", run(TestCase{
 		args: []string{
 			"basic.string=test",