scw create/run can take a snapshot as root volume (Fixes #19)

Author: moul

README.md

@@ -950,6 +950,10 @@ Same as Hack, without step 5
 
 ### master (unreleased)
 
+#### Features
+
+* `scw {create,run} IMAGE`, *IMAGE* can be a snapshot ([#19](https://github.com/scaleway/scaleway-cli/issues/19))
+
 #### Fixes
 
 * `scw run IMAGE [COMMAND]`, default *COMMAND* is now `if [ -x /bin/bash ]; then exec /bin/bash; else exec /bin/sh; fi`

api/api.go

@@ -1143,7 +1143,7 @@ func (s *ScalewayAPI) GetSnapshotID(needle string) string {
 }
 
 // GetImageID returns exactly one image matching or dies
-func (s *ScalewayAPI) GetImageID(needle string) string {
+func (s *ScalewayAPI) GetImageID(needle string, exitIfMissing bool) string {
 	images, err := s.ResolveImage(needle)
 	if err != nil {
 		log.Fatalf("Unable to resolve image %s: %s", needle, err)
@@ -1152,7 +1152,11 @@ func (s *ScalewayAPI) GetImageID(needle string) string {
 		return images[0]
 	}
 	if len(images) == 0 {
-		log.Fatalf("No such image: %s", needle)
+		if exitIfMissing {
+			log.Fatalf("No such image: %s", needle)
+		} else {
+			return ""
+		}
 	}
 	log.Errorf("Too many candidates for %s (%d)", needle, len(images))
 	for _, identifier := range images {

api/helpers.go

@@ -241,8 +241,16 @@ func CreateServer(api *ScalewayAPI, imageName string, name string, bootscript st
 	} else {
 		// Use an existing image
 		// FIXME: handle snapshots
-		image := api.GetImageID(imageName)
-		server.Image = &image
+		image := api.GetImageID(imageName, false)
+		if image != "" {
+			server.Image = &image
+		}
+		snapshotID := api.GetSnapshotID(imageName)
+		snapshot, err := api.GetSnapshot(snapshotID)
+		if err != nil {
+			return "", err
+		}
+		server.Volumes["0"] = snapshot.BaseVolume.Identifier
 	}
 
 	serverID, err := api.PostServer(server)

commands/history.go

@@ -39,7 +39,7 @@ func runHistory(cmd *types.Command, args []string) {
 		cmd.PrintShortUsage()
 	}
 
-	imageID := cmd.API.GetImageID(args[0])
+	imageID := cmd.API.GetImageID(args[0], true)
 	image, err := cmd.API.GetImage(imageID)
 	if err != nil {
 		log.Fatalf("Cannot get image %s: %v", imageID, err)

commands/rmi.go

@@ -40,7 +40,7 @@ func runRmi(cmd *types.Command, args []string) {
 	}
 	hasError := false
 	for _, needle := range args {
-		image := cmd.API.GetImageID(needle)
+		image := cmd.API.GetImageID(needle, true)
 		err := cmd.API.DeleteImage(image)
 		if err != nil {
 			log.Errorf("failed to delete image %s: %s", image, err)