Skip to content

Commit 924cbb6

Browse files
authored
Revert "feat(redis): require the node_type field in MigrateClusterRequest"
This reverts merge request !3058 (#3706)
1 parent 79c711d commit 924cbb6

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

cmd/scw/testdata/test-all-usage-redis-cluster-migrate-usage.golden

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ USAGE:
77

88
ARGS:
99
[version] Redis™ engine version of the Database Instance
10-
node-type Type of node to use for the Database Instance
10+
[node-type] Type of node to use for the Database Instance
1111
[cluster-size] Number of nodes for the Database Instance
1212
cluster-id UUID of the Database Instance to update
1313
[zone=fr-par-1] Zone to target. If none is passed will use default zone from the config (fr-par-1 | fr-par-2 | nl-ams-1 | nl-ams-2 | pl-waw-1 | pl-waw-2)

docs/commands/redis.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -287,7 +287,7 @@ scw redis cluster migrate <cluster-id ...> [arg=value ...]
287287
| Name | | Description |
288288
|------|---|-------------|
289289
| version | | Redis™ engine version of the Database Instance |
290-
| node-type | Required | Type of node to use for the Database Instance |
290+
| node-type | | Type of node to use for the Database Instance |
291291
| cluster-size | | Number of nodes for the Database Instance |
292292
| cluster-id | Required | UUID of the Database Instance to update |
293293
| zone | Default: `fr-par-1`<br />One of: `fr-par-1`, `fr-par-2`, `nl-ams-1`, `nl-ams-2`, `pl-waw-1`, `pl-waw-2` | Zone to target. If none is passed will use default zone from the config |

internal/namespaces/redis/v1/redis_cli.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -421,7 +421,7 @@ func redisClusterMigrate() *core.Command {
421421
{
422422
Name: "node-type",
423423
Short: `Type of node to use for the Database Instance`,
424-
Required: true,
424+
Required: false,
425425
Deprecated: false,
426426
Positional: false,
427427
},

0 commit comments

Comments
 (0)