Skip to content

Commit a77f07a

Browse files
chore: deprecate trigger Create commands (#3429)
Co-authored-by: Rémy Léone <[email protected]>
1 parent 11598a5 commit a77f07a

File tree

6 files changed

+16
-12
lines changed

6 files changed

+16
-12
lines changed

cmd/scw/testdata/test-all-usage-container-trigger-create-usage.golden

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,21 +9,23 @@ ARGS:
99
[name]
1010
[description]
1111
[container-id]
12-
[scw-sqs-config.mnq-namespace-id]
1312
[scw-sqs-config.queue]
1413
[scw-sqs-config.mnq-project-id]
1514
[scw-sqs-config.mnq-region]
1615
[sqs-config.endpoint]
1716
[sqs-config.queue-url]
1817
[sqs-config.access-key]
1918
[sqs-config.secret-key]
20-
[scw-nats-config.mnq-namespace-id]
2119
[scw-nats-config.subject]
2220
[scw-nats-config.mnq-project-id]
2321
[scw-nats-config.mnq-region]
2422
[scw-nats-config.mnq-nats-account-id]
2523
[region=fr-par] Region to target. If none is passed will use default region from the config (fr-par | nl-ams | pl-waw)
2624

25+
DEPRECATED ARGS:
26+
[scw-sqs-config.mnq-namespace-id]
27+
[scw-nats-config.mnq-namespace-id]
28+
2729
FLAGS:
2830
-h, --help help for create
2931

cmd/scw/testdata/test-all-usage-function-trigger-create-usage.golden

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,21 +9,23 @@ ARGS:
99
[name]
1010
[description]
1111
[function-id]
12-
[scw-sqs-config.mnq-namespace-id]
1312
[scw-sqs-config.queue]
1413
[scw-sqs-config.mnq-project-id]
1514
[scw-sqs-config.mnq-region]
1615
[sqs-config.endpoint]
1716
[sqs-config.queue-url]
1817
[sqs-config.access-key]
1918
[sqs-config.secret-key]
20-
[scw-nats-config.mnq-namespace-id]
2119
[scw-nats-config.subject]
2220
[scw-nats-config.mnq-project-id]
2321
[scw-nats-config.mnq-region]
2422
[scw-nats-config.mnq-nats-account-id]
2523
[region=fr-par] Region to target. If none is passed will use default region from the config (fr-par | nl-ams | pl-waw)
2624

25+
DEPRECATED ARGS:
26+
[scw-sqs-config.mnq-namespace-id]
27+
[scw-nats-config.mnq-namespace-id]
28+
2729
FLAGS:
2830
-h, --help help for create
2931

docs/commands/container.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -686,15 +686,15 @@ scw container trigger create [arg=value ...]
686686
| name | | |
687687
| description | | |
688688
| container-id | | |
689-
| scw-sqs-config.mnq-namespace-id | | |
689+
| ~~scw-sqs-config.mnq-namespace-id~~ | Deprecated | |
690690
| scw-sqs-config.queue | | |
691691
| scw-sqs-config.mnq-project-id | | |
692692
| scw-sqs-config.mnq-region | | |
693693
| sqs-config.endpoint | | |
694694
| sqs-config.queue-url | | |
695695
| sqs-config.access-key | | |
696696
| sqs-config.secret-key | | |
697-
| scw-nats-config.mnq-namespace-id | | |
697+
| ~~scw-nats-config.mnq-namespace-id~~ | Deprecated | |
698698
| scw-nats-config.subject | | |
699699
| scw-nats-config.mnq-project-id | | |
700700
| scw-nats-config.mnq-region | | |

docs/commands/function.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -743,15 +743,15 @@ scw function trigger create [arg=value ...]
743743
| name | | |
744744
| description | | |
745745
| function-id | | |
746-
| scw-sqs-config.mnq-namespace-id | | |
746+
| ~~scw-sqs-config.mnq-namespace-id~~ | Deprecated | |
747747
| scw-sqs-config.queue | | |
748748
| scw-sqs-config.mnq-project-id | | |
749749
| scw-sqs-config.mnq-region | | |
750750
| sqs-config.endpoint | | |
751751
| sqs-config.queue-url | | |
752752
| sqs-config.access-key | | |
753753
| sqs-config.secret-key | | |
754-
| scw-nats-config.mnq-namespace-id | | |
754+
| ~~scw-nats-config.mnq-namespace-id~~ | Deprecated | |
755755
| scw-nats-config.subject | | |
756756
| scw-nats-config.mnq-project-id | | |
757757
| scw-nats-config.mnq-region | | |

internal/namespaces/container/v1beta1/container_cli.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1412,7 +1412,7 @@ func containerTriggerCreate() *core.Command {
14121412
{
14131413
Name: "scw-sqs-config.mnq-namespace-id",
14141414
Required: false,
1415-
Deprecated: false,
1415+
Deprecated: true,
14161416
Positional: false,
14171417
},
14181418
{
@@ -1460,7 +1460,7 @@ func containerTriggerCreate() *core.Command {
14601460
{
14611461
Name: "scw-nats-config.mnq-namespace-id",
14621462
Required: false,
1463-
Deprecated: false,
1463+
Deprecated: true,
14641464
Positional: false,
14651465
},
14661466
{

internal/namespaces/function/v1beta1/function_cli.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1510,7 +1510,7 @@ func functionTriggerCreate() *core.Command {
15101510
{
15111511
Name: "scw-sqs-config.mnq-namespace-id",
15121512
Required: false,
1513-
Deprecated: false,
1513+
Deprecated: true,
15141514
Positional: false,
15151515
},
15161516
{
@@ -1558,7 +1558,7 @@ func functionTriggerCreate() *core.Command {
15581558
{
15591559
Name: "scw-nats-config.mnq-namespace-id",
15601560
Required: false,
1561-
Deprecated: false,
1561+
Deprecated: true,
15621562
Positional: false,
15631563
},
15641564
{

0 commit comments

Comments
 (0)