Skip to content

Commit b752247

Browse files
feat(secret_manager): remove tag command from CLI (#3748)
Co-authored-by: Mia-Cross <[email protected]>
1 parent 5b4f5d0 commit b752247

File tree

6 files changed

+6
-32
lines changed

6 files changed

+6
-32
lines changed

cmd/scw/testdata/test-all-usage-secret-secret-create-usage.golden

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
🎲🎲🎲 EXIT CODE: 0 🎲🎲🎲
22
🟥🟥🟥 STDERR️️ 🟥🟥🟥️
3-
You must specify the `region` to create a secret.
3+
Create a secret in a given region specified by the `region` parameter.
44

55
USAGE:
66
scw secret secret create [arg=value ...]

cmd/scw/testdata/test-all-usage-secret-usage.golden

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ USAGE:
77

88
AVAILABLE COMMANDS:
99
secret Secret management commands
10-
tag Tag management commands
1110
version Secret Version management commands
1211

1312
FLAGS:

docs/commands/secret.md

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ This API allows you to conveniently store, access and share sensitive data such
1111
- [Enable secret protection](#enable-secret-protection)
1212
- [Disable secret protection](#disable-secret-protection)
1313
- [Update metadata of a secret](#update-metadata-of-a-secret)
14-
- [Tag management commands](#tag-management-commands)
1514
- [Secret Version management commands](#secret-version-management-commands)
1615
- [Access a secret's version using the secret's ID](#access-a-secret's-version-using-the-secret's-id)
1716
- [Create a version](#create-a-version)
@@ -51,7 +50,7 @@ scw secret secret add-owner <secret-id ...> [arg=value ...]
5150

5251
### Create a secret
5352

54-
You must specify the `region` to create a secret.
53+
Create a secret in a given region specified by the `region` parameter.
5554

5655
**Usage:**
5756

@@ -252,20 +251,6 @@ scw secret secret update <secret-id ...> [arg=value ...]
252251

253252

254253

255-
## Tag management commands
256-
257-
Tag management commands.
258-
259-
Tag management commands.
260-
261-
**Usage:**
262-
263-
```
264-
scw secret tag
265-
```
266-
267-
268-
269254
## Secret Version management commands
270255

271256
Versions store the sensitive data contained in your secrets (API keys, passwords, or certificates).

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ require (
2424
github.com/moby/buildkit v0.11.6
2525
github.com/opencontainers/go-digest v1.0.0
2626
github.com/pkg/errors v0.9.1
27-
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.25.0.20240329152759-b47741a7bf2a
27+
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.25.0.20240404123609-0262fe19b753
2828
github.com/skratchdot/open-golang v0.0.0-20200116055534-eef842397966
2929
github.com/spf13/cobra v1.8.0
3030
github.com/spf13/pflag v1.0.5

go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -425,8 +425,8 @@ github.com/rogpeppe/go-internal v1.11.0/go.mod h1:ddIwULY96R17DhadqLgMfk9H9tvdUz
425425
github.com/russross/blackfriday/v2 v2.1.0/go.mod h1:+Rmxgy9KzJVeS9/2gXHxylqXiyQDYRxCVz55jmeOWTM=
426426
github.com/sabhiram/go-gitignore v0.0.0-20210923224102-525f6e181f06 h1:OkMGxebDjyw0ULyrTYWeN0UNCCkmCWfjPnIA2W6oviI=
427427
github.com/sabhiram/go-gitignore v0.0.0-20210923224102-525f6e181f06/go.mod h1:+ePHsJ1keEjQtpvf9HHw0f4ZeJ0TLRsxhunSI2hYJSs=
428-
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.25.0.20240329152759-b47741a7bf2a h1:C1cHJWg9ko/9GwhCMD6mY8x0/R4bJd2TA5K0iMaM6eA=
429-
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.25.0.20240329152759-b47741a7bf2a/go.mod h1:fCa7OJZ/9DRTnOKmxvT6pn+LPWUptQAmHF/SBJUGEcg=
428+
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.25.0.20240404123609-0262fe19b753 h1:560ZctptQdKx0KGFRZ9r8Hx8bMRv86c/xvgCKt0EHas=
429+
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.25.0.20240404123609-0262fe19b753/go.mod h1:fCa7OJZ/9DRTnOKmxvT6pn+LPWUptQAmHF/SBJUGEcg=
430430
github.com/sclevine/spec v1.4.0 h1:z/Q9idDcay5m5irkZ28M7PtQM4aOISzOpj4bUPkDee8=
431431
github.com/sclevine/spec v1.4.0/go.mod h1:LvpgJaFyvQzRvc1kaDs0bulYwzC70PbiYjC4QnFHkOM=
432432
github.com/secure-systems-lab/go-securesystemslib v0.4.0 h1:b23VGrQhTA8cN2CbBw7/FulN9fTtqYUdS5+Oxzt+DUE=

internal/namespaces/secret/v1beta1/secret_cli.go

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ func GetGeneratedCommands() *core.Commands {
2222
secretRoot(),
2323
secretSecret(),
2424
secretVersion(),
25-
secretTag(),
2625
secretSecretCreate(),
2726
secretSecretGet(),
2827
secretSecretUpdate(),
@@ -67,19 +66,10 @@ func secretVersion() *core.Command {
6766
}
6867
}
6968

70-
func secretTag() *core.Command {
71-
return &core.Command{
72-
Short: `Tag management commands`,
73-
Long: `Tag management commands.`,
74-
Namespace: "secret",
75-
Resource: "tag",
76-
}
77-
}
78-
7969
func secretSecretCreate() *core.Command {
8070
return &core.Command{
8171
Short: `Create a secret`,
82-
Long: `You must specify the ` + "`" + `region` + "`" + ` to create a secret.`,
72+
Long: `Create a secret in a given region specified by the ` + "`" + `region` + "`" + ` parameter.`,
8373
Namespace: "secret",
8474
Resource: "secret",
8575
Verb: "create",

0 commit comments

Comments
 (0)