feat(instance): set bootscript as deprecated in the public api (#2758)

Co-authored-by: Rémy Léone <[email protected]>

Author: scaleway-bot

cmd/scw/testdata/test-all-usage-instance-image-create-usage.golden

@@ -13,7 +13,6 @@ ARGS:
   [name=<generated>]                           Name of the image
   snapshot-id                                  UUID of the snapshot that will be used as root volume in the image
   arch                                         Architecture of the image (x86_64 | arm)
-  [default-bootscript]                         Default bootscript of the image
   [additional-snapshots.{index}.id]            UUID of the snapshot to add
   [additional-snapshots.{index}.name]          Name of the additional snapshot
   [additional-snapshots.{index}.size]          Size of the additional snapshot
@@ -26,6 +25,7 @@ ARGS:
   [zone=fr-par-1]                              Zone to target. If none is passed will use default zone from the config (fr-par-1 | fr-par-2 | fr-par-3 | nl-ams-1 | nl-ams-2 | pl-waw-1 | pl-waw-2)
 
 DEPRECATED ARGS:
+  [default-bootscript]                             Default bootscript of the image
   [additional-snapshots.{index}.organization-id]   Organization ID that own the additional snapshot
 
 FLAGS:

cmd/scw/testdata/test-all-usage-instance-server-update-usage.golden

@@ -35,7 +35,6 @@ ARGS:
   [volumes.{key}.base-snapshot]               The ID of the snapshot on which this volume will be based
   [volumes.{key}.project]                     Project ID of the volume
   [volumes.{key}.organization]                Organization ID of the volume
-  [bootscript]                                
   [dynamic-ip-required]                       
   [enable-ipv6]                               
   [protected]                                 
@@ -49,6 +48,9 @@ ARGS:
   [private-nics.{index}.state]                The private NIC state (available | syncing | syncing_error)
   [zone=fr-par-1]                             Zone to target. If none is passed will use default zone from the config (fr-par-1 | fr-par-2 | fr-par-3 | nl-ams-1 | nl-ams-2 | pl-waw-1 | pl-waw-2)
 
+DEPRECATED ARGS:
+  [bootscript]   
+
 FLAGS:
   -h, --help   help for update
 

docs/commands/instance.md

@@ -105,7 +105,7 @@ scw instance image create [arg=value ...]
 | name | Default: `<generated>` | Name of the image |
 | snapshot-id | Required | UUID of the snapshot that will be used as root volume in the image |
 | arch | Required<br />One of: `x86_64`, `arm` | Architecture of the image |
-| default-bootscript |  | Default bootscript of the image |
+| ~~default-bootscript~~ | Deprecated | Default bootscript of the image |
 | additional-snapshots.{index}.id |  | UUID of the snapshot to add |
 | additional-snapshots.{index}.name |  | Name of the additional snapshot |
 | additional-snapshots.{index}.size |  | Size of the additional snapshot |
@@ -1823,7 +1823,7 @@ scw instance server update <server-id ...> [arg=value ...]
 | volumes.{key}.base-snapshot |  | The ID of the snapshot on which this volume will be based |
 | volumes.{key}.project |  | Project ID of the volume |
 | volumes.{key}.organization |  | Organization ID of the volume |
-| bootscript |  |  |
+| ~~bootscript~~ | Deprecated |  |
 | dynamic-ip-required |  |  |
 | enable-ipv6 |  |  |
 | protected |  |  |

go.mod

@@ -18,7 +18,7 @@ require (
 	github.com/kubernetes-client/go-base v0.0.0-20190205182333-3d0e39759d98
 	github.com/mattn/go-colorable v0.1.13
 	github.com/mattn/go-isatty v0.0.17
-	github.com/scaleway/scaleway-sdk-go v1.0.0-beta.12.0.20230203110828-1b2807d77032
+	github.com/scaleway/scaleway-sdk-go v1.0.0-beta.13
 	github.com/spf13/cobra v1.6.1
 	github.com/spf13/pflag v1.0.5
 	github.com/stretchr/testify v1.8.1

go.sum

@@ -70,8 +70,8 @@ github.com/pkg/term v1.1.0/go.mod h1:E25nymQcrSllhX42Ok8MRm1+hyBdHY0dCeiKZ9jpNGw
 github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM=
 github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
 github.com/russross/blackfriday/v2 v2.1.0/go.mod h1:+Rmxgy9KzJVeS9/2gXHxylqXiyQDYRxCVz55jmeOWTM=
-github.com/scaleway/scaleway-sdk-go v1.0.0-beta.12.0.20230203110828-1b2807d77032 h1:U2vE7i6HU67qiuXWWtdjzHDUaspEdF+CnHPFHZTsSds=
-github.com/scaleway/scaleway-sdk-go v1.0.0-beta.12.0.20230203110828-1b2807d77032/go.mod h1:fCa7OJZ/9DRTnOKmxvT6pn+LPWUptQAmHF/SBJUGEcg=
+github.com/scaleway/scaleway-sdk-go v1.0.0-beta.13 h1:n5J2K6g/kl/iT6mODjCoSoRBGQVmIG3aMtYbofi9kxc=
+github.com/scaleway/scaleway-sdk-go v1.0.0-beta.13/go.mod h1:fCa7OJZ/9DRTnOKmxvT6pn+LPWUptQAmHF/SBJUGEcg=
 github.com/sergi/go-diff v1.2.0 h1:XU+rvMAioB0UC3q1MFrIQy4Vo5/4VsRDQQXHsEya6xQ=
 github.com/sergi/go-diff v1.2.0/go.mod h1:STckp+ISIX8hZLjrqAeVduY0gWCT9IjLuqbuNXdaHfM=
 github.com/spf13/cobra v1.6.1 h1:o94oiPyS4KD1mPy2fmcYYHHfCxLqYjJOhGsCHFZtEzA=

internal/namespaces/instance/v1/instance_cli.go

@@ -631,7 +631,7 @@ func instanceServerUpdate() *core.Command {
 			{
 				Name:       "bootscript",
 				Required:   false,
-				Deprecated: false,
+				Deprecated: true,
 				Positional: false,
 			},
 			{
@@ -1074,7 +1074,7 @@ func instanceImageCreate() *core.Command {
 				Name:       "default-bootscript",
 				Short:      `Default bootscript of the image`,
 				Required:   false,
-				Deprecated: false,
+				Deprecated: true,
 				Positional: false,
 			},
 			{