Merge branch 'master' into feat/cookbook-restore-backup-cross-instance

Author: jremy42

.github/workflows/unit-tests.yaml renamed to .github/workflows/build.yml

@@ -1,4 +1,4 @@
-name: Tests
+name: Build
 
 permissions:
   contents: read
@@ -8,16 +8,9 @@ on:
   merge_group:
 
 jobs:
-  os-tests:
-    strategy:
-      matrix:
-        platform: [ubuntu-latest, macos-latest, windows-latest]
-    runs-on: ${{ matrix.platform }}
+  native-binary:
+    runs-on: ubuntu-latest
     steps:
-      - name: Set git to use LF to avoid problem with goldens on windows
-        run: |
-          git config --global core.autocrlf false
-          git config --global core.eol lf
       # Checkout should always be before setup-go to ensure caching is working
       - name: Checkout
         uses: actions/checkout@v5
@@ -31,31 +24,14 @@ jobs:
         run: |
           go mod tidy
           git diff --exit-code
-      - name: Run unit tests
-        run: go tool gotestsum --format github-actions
-      - name: Execute main binary # Test the runtime for potential panics.
-        run: go run cmd/scw/main.go -h
-
-  build-tests:
-    runs-on: ubuntu-latest
-    steps:
-      # Checkout should always be before setup-go to ensure caching is working
-      - name: Checkout
-        uses: actions/checkout@v5
-        with:
-          fetch-depth: 1
-      - name: Install Go
-        uses: actions/setup-go@v6
-        with:
-          go-version: stable
       - name: Build binaries
         run: ./scripts/build.sh
       - name: Print binaries size
         run: ls -lh ./bin
       - name: Check binary size
         run: ./scripts/check-size.sh ./bin/*linux-x86_64
 
-  docker-tests:
+  docker:
     runs-on: ubuntu-latest
     steps:
     - name: Checkout

.github/workflows/codeql-analysis.yml

@@ -48,7 +48,7 @@ jobs:
 
     # Initializes the CodeQL tools for scanning.
     - name: Initialize CodeQL
-      uses: github/codeql-action/init@v3
+      uses: github/codeql-action/init@v4
       with:
         languages: ${{ matrix.language }}
         # If you wish to specify custom queries, you can do so here or in a config file.
@@ -59,7 +59,7 @@ jobs:
     # Autobuild attempts to build any compiled languages  (C/C++, C#, or Java).
     # If this step fails, then you should remove it and run the build manually (see below)
     - name: Autobuild
-      uses: github/codeql-action/autobuild@v3
+      uses: github/codeql-action/autobuild@v4
 
     # ℹ️ Command-line programs to run using the OS shell.
     # 📚 https://git.io/JvXDl
@@ -73,4 +73,4 @@ jobs:
     #   make release
 
     - name: Perform CodeQL Analysis
-      uses: github/codeql-action/analyze@v3
+      uses: github/codeql-action/analyze@v4

.github/workflows/lint.yml

@@ -37,3 +37,14 @@ jobs:
           # Required: the version of golangci-lint is required and must be specified without patch version: we always use the latest patch version.
           version: latest
           args: --timeout 10m
+
+  spelling:
+    name: Spell Check with Typos
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout Actions Repository
+        uses: actions/checkout@v4
+      - name: Spell Check Repo
+        uses: crate-ci/[email protected]
+        env:
+          CLICOLOR: 1

.github/workflows/tests.yml

@@ -0,0 +1,86 @@
+name: Tests
+
+permissions:
+  contents: read
+
+on:
+  pull_request:
+  merge_group:
+
+jobs:
+  namespaces:
+    strategy:
+      matrix:
+        platform:
+          - ubuntu-latest
+          - macos-latest
+          - windows-latest
+        products:
+          - account
+          - applesilicon
+          - baremetal
+          - billing
+          - block
+          - cockpit
+          - container
+          - dedibox
+          - domain
+          - edge_services
+          - flexibleip
+          - function
+          - iam
+          - inference
+          - init
+          - instance
+          - iot
+          - ipam
+          - jobs
+          - k8s
+          - key_manager
+          - lb
+          - login
+          - marketplace
+          - mnq
+          - mongodb
+          - object
+          - rdb
+          - redis
+          - registry
+          - serverless_sqldb
+          - secret
+          - tem
+          - vpc
+          - vpcgw
+          - webhosting
+    runs-on: ${{ matrix.platform }}
+    steps:
+      - name: Set git to use LF to avoid problem with goldens on windows
+        run: |
+          git config --global core.autocrlf false
+          git config --global core.eol lf
+      # Checkout should always be before setup-go to ensure caching is working
+      - name: Checkout
+        uses: actions/checkout@v5
+        with:
+          fetch-depth: 1
+      - name: Install Go
+        uses: actions/setup-go@v6
+        with:
+          go-version: stable
+      - name: Run tests
+        run: go tool gotestsum --format github-actions -- -v ./internal/namespaces/${{ matrix.products }}/...
+      - name: Execute main binary # Test the runtime for potential panics.
+        run: go run cmd/scw/main.go -h
+  others:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v5
+        with:
+          fetch-depth: 1
+      - name: Install Go
+        uses: actions/setup-go@v6
+        with:
+          go-version: stable
+      - name: Run tests outside of products namespaces
+        run: go list ./... | grep -v 'internal/namespaces' | xargs go tool gotestsum --format github-actions -- -v

_typos.toml

@@ -0,0 +1,16 @@
+[files]
+extend-exclude = [
+    "**.cassette.yaml",
+    "**.golden",
+    "go.mod",
+    "go.sum",
+    "CHANGELOG.md"
+]
+
+[default.extend-words]
+pn = "pn"
+thi = "thi"
+Vertexes = "Vertexes"
+ba = "ba"
+Viw = "Viw"
+UE = "UE"

cmd/scw/testdata/test-all-usage-apple-silicon-server-reinstall-usage.golden

@@ -1,6 +1,6 @@
 🎲🎲🎲 EXIT CODE: 0 🎲🎲🎲
 🟥🟥🟥 STDERR️️ 🟥🟥🟥️
-Reinstall an existing Apple silicon server (specified by its server ID) from a new image (OS). All the data on the disk is deleted and all configuration is reset to the defailt configuration values of the image (OS).
+Reinstall an existing Apple silicon server (specified by its server ID) from a new image (OS). All the data on the disk is deleted and all configuration is reset to the default configuration values of the image (OS).
 
 USAGE:
   scw apple-silicon server reinstall <server-id ...> [arg=value ...]

cmd/scw/testdata/test-all-usage-audit-trail-event-list-usage.golden

@@ -7,7 +7,7 @@ USAGE:
 
 ARGS:
   [project-id]        (Optional) ID of the Project containing the Audit Trail events
-  [resource-type]     (Optional) Type of the Scaleway resource (unknown_type | secm_secret | secm_secret_version | kube_cluster | kube_pool | kube_node | kube_acl | keym_key | iam_user | iam_application | iam_group | iam_policy | iam_api_key | iam_ssh_key | iam_rule | iam_saml | iam_saml_certificate | secret_manager_secret | secret_manager_version | key_manager_key | account_user | account_organization | account_project | instance_server | instance_placement_group | instance_security_group | instance_volume | instance_snapshot | instance_image | apple_silicon_server | baremetal_server | baremetal_setting | ipam_ip | sbs_volume | sbs_snapshot | load_balancer_lb | load_balancer_ip | load_balancer_frontend | load_balancer_backend | load_balancer_route | load_balancer_acl | load_balancer_certificate | sfs_filesystem | vpc_private_network)
+  [resource-type]     (Optional) Type of the Scaleway resource (unknown_type | secm_secret | secm_secret_version | kube_cluster | kube_pool | kube_node | kube_acl | keym_key | iam_user | iam_application | iam_group | iam_policy | iam_api_key | iam_ssh_key | iam_rule | iam_saml | iam_saml_certificate | secret_manager_secret | secret_manager_version | key_manager_key | account_user | account_organization | account_project | instance_server | instance_placement_group | instance_security_group | instance_volume | instance_snapshot | instance_image | apple_silicon_server | baremetal_server | baremetal_setting | ipam_ip | sbs_volume | sbs_snapshot | load_balancer_lb | load_balancer_ip | load_balancer_frontend | load_balancer_backend | load_balancer_route | load_balancer_acl | load_balancer_certificate | sfs_filesystem | vpc_private_network | edge_services_plan | edge_services_pipeline | edge_services_dns_stage | edge_services_tls_stage | edge_services_cache_stage | edge_services_route_stage | edge_services_route_rules | edge_services_waf_stage | edge_services_backend_stage)
   [method-name]       (Optional) Name of the method of the API call performed
   [status]            (Optional) HTTP status code of the request. Returns either `200` if the request was successful or `403` if the permission was denied
   [recorded-after]    (Optional) The `recorded_after` parameter defines the earliest timestamp from which Audit Trail events are retrieved. Returns `one hour ago` by default

cmd/scw/testdata/test-all-usage-cockpit-managed-alerts-enable-usage.golden

@@ -1,6 +1,6 @@
 🎲🎲🎲 EXIT CODE: 0 🎲🎲🎲
 🟥🟥🟥 STDERR️️ 🟥🟥🟥️
-Enable the sending of managed alerts for the specified Project. Managed alerts are predefined alerts that apply to Scaleway recources integrated with Cockpit by default.
+Enable the sending of managed alerts for the specified Project. Managed alerts are predefined alerts that apply to Scaleway resources integrated with Cockpit by default.
 
 USAGE:
   scw cockpit managed-alerts enable [arg=value ...]

cmd/scw/testdata/test-all-usage-container-cron-create-usage.golden

@@ -7,7 +7,7 @@ USAGE:
 
 ARGS:
   [container-id]    UUID of the container to invoke by the cron
-  [schedule]        UNIX cron shedule
+  [schedule]        UNIX cron schedule
   [args]            Arguments to pass with the cron
   [name]            Name of the cron to create
   [region=fr-par]   Region to target. If none is passed will use default region from the config (fr-par | nl-ams | pl-waw)

cmd/scw/testdata/test-all-usage-dns-certificate-get-usage.golden

@@ -1,6 +1,6 @@
 🎲🎲🎲 EXIT CODE: 0 🎲🎲🎲
 🟥🟥🟥 STDERR️️ 🟥🟥🟥️
-Get the DNS zone's TLS certificate. If you do not have a certificate, the ouptut returns `no certificate found`.
+Get the DNS zone's TLS certificate. If you do not have a certificate, the output returns `no certificate found`.
 
 USAGE:
   scw dns certificate get <dns-zone ...> [arg=value ...]