fix: proper file descriptor for shell configuration (#675)

loicbourgois · web-flow · commit c901a0abbb21 · 2020-02-10T17:54:08.000+01:00
diff --git a/internal/namespaces/autocomplete/autocomplete.go b/internal/namespaces/autocomplete/autocomplete.go
@@ -182,7 +182,7 @@ func InstallCommandRun(ctx context.Context, argsI interface{}) (i interface{}, e
 	}
 
 	// If the file doesn't exist, create it
-	f, err := os.OpenFile(shellConfigurationFilePath, os.O_APPEND|os.O_CREATE|os.O_WRONLY, 0644)
+	f, err := os.OpenFile(shellConfigurationFilePath, os.O_RDWR|os.O_CREATE|os.O_APPEND, 0644)
 	if f != nil {
 		defer f.Close()
 	}

Original file line number	Diff line number	Diff line change
`@@ -182,7 +182,7 @@ func InstallCommandRun(ctx context.Context, argsI interface{}) (i interface{}, e`
`182`	`182`	`}`
`183`	`183`
`184`	`184`	`// If the file doesn't exist, create it`
`185`		`- f, err := os.OpenFile(shellConfigurationFilePath, os.O_APPEND\|os.O_CREATE\|os.O_WRONLY, 0644)`
	`185`	`+ f, err := os.OpenFile(shellConfigurationFilePath, os.O_RDWR\|os.O_CREATE\|os.O_APPEND, 0644)`
`186`	`186`	`if f != nil {`
`187`	`187`	`defer f.Close()`
`188`	`188`	`}`