Skip to content

Commit cbdd077

Browse files
author
Quentin Perez
authored
Merge pull request #422 from QuentinPerez/fix-ps
fix: ps --filter
2 parents d0e4533 + 0d4fd27 commit cbdd077

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

README.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1201,6 +1201,10 @@ $ scw inspect myserver | jq '.[0].public_ip.address'
12011201

12021202
## Changelog
12031203

1204+
### master (unreleased)
1205+
1206+
* `scw ps` do not display empty server with --filter
1207+
12041208
### v1.10.1 (2016-10-24)
12051209

12061210
* `scw login` fix CheckCredentials ([418](https://github.com/scaleway/scaleway-cli/issues/418))

pkg/commands/ps.go

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,7 @@ func RunPs(ctx CommandContext, args PsArgs) error {
5353
logrus.Warnf("Unknown filter: '%s=%s'", key, value)
5454
}
5555
}
56-
filtered := make([]api.ScalewayServer, len(*servers))
57-
index := 0
56+
filtered := make([]api.ScalewayServer, 0, len(*servers))
5857
for _, server := range *servers {
5958
// filtering
6059
for key, value := range args.Filters {
@@ -100,8 +99,7 @@ func RunPs(ctx CommandContext, args PsArgs) error {
10099
}
101100
}
102101
}
103-
filtered[index] = server
104-
index++
102+
filtered = append(filtered, server)
105103
skipServer:
106104
continue
107105
}

0 commit comments

Comments
 (0)