fix(lb): change default value for assign_flexible_ip (#3875)

Author: scaleway-bot

cmd/scw/testdata/test-all-usage-lblb-create-usage.golden

@@ -6,17 +6,17 @@ USAGE:
   scw lb lb create [arg=value ...]
 
 ARGS:
-  [project-id]                Project ID to use. If none is passed the default project ID will be used
-  name=<generated>            Name for the Load Balancer
-  [description]               Description for the Load Balancer
-  [assign-flexible-ip]        Defines whether to automatically assign a flexible public IP to lb. Default value is `false` (do not assign).
-  [assign-flexible-ipv6]      Defines whether to automatically assign a flexible public IPv6 to the Load Balancer. Default value is `false` (do not assign).
-  [ip-ids.{index}]            List of IP IDs to attach to the Load Balancer
-  [tags.{index}]              List of tags for the Load Balancer
-  [type=LB-S]                 Load Balancer commercial offer type. Use the Load Balancer types endpoint to retrieve a list of available offer types (LB-S | LB-GP-M | LB-GP-L)
-  [ssl-compatibility-level]   Determines the minimal SSL version which needs to be supported on the client side, in an SSL/TLS offloading context. Intermediate is suitable for general-purpose servers with a variety of clients, recommended for almost all systems. Modern is suitable for services with clients that support TLS 1.3 and do not need backward compatibility. Old is compatible with a small number of very old clients and should be used only as a last resort (ssl_compatibility_level_unknown | ssl_compatibility_level_intermediate | ssl_compatibility_level_modern | ssl_compatibility_level_old)
-  [organization-id]           Organization ID to use. If none is passed the default organization ID will be used
-  [zone=fr-par-1]             Zone to target. If none is passed will use default zone from the config (fr-par-1 | fr-par-2 | nl-ams-1 | nl-ams-2 | nl-ams-3 | pl-waw-1 | pl-waw-2 | pl-waw-3)
+  [project-id]                   Project ID to use. If none is passed the default project ID will be used
+  name=<generated>               Name for the Load Balancer
+  [description]                  Description for the Load Balancer
+  [assign-flexible-ip=true]      Defines whether to automatically assign a flexible public IP to the Load Balancer. Default value is `true` (assign).
+  [assign-flexible-ipv6=false]   Defines whether to automatically assign a flexible public IPv6 to the Load Balancer. Default value is `false` (do not assign).
+  [ip-ids.{index}]               List of IP IDs to attach to the Load Balancer
+  [tags.{index}]                 List of tags for the Load Balancer
+  [type=LB-S]                    Load Balancer commercial offer type. Use the Load Balancer types endpoint to retrieve a list of available offer types (LB-S | LB-GP-M | LB-GP-L)
+  [ssl-compatibility-level]      Determines the minimal SSL version which needs to be supported on the client side, in an SSL/TLS offloading context. Intermediate is suitable for general-purpose servers with a variety of clients, recommended for almost all systems. Modern is suitable for services with clients that support TLS 1.3 and do not need backward compatibility. Old is compatible with a small number of very old clients and should be used only as a last resort (ssl_compatibility_level_unknown | ssl_compatibility_level_intermediate | ssl_compatibility_level_modern | ssl_compatibility_level_old)
+  [organization-id]              Organization ID to use. If none is passed the default organization ID will be used
+  [zone=fr-par-1]                Zone to target. If none is passed will use default zone from the config (fr-par-1 | fr-par-2 | nl-ams-1 | nl-ams-2 | nl-ams-3 | pl-waw-1 | pl-waw-2 | pl-waw-3)
 
 DEPRECATED ARGS:
   [ip-id]   ID of an existing flexible IP address to attach to the Load Balancer

docs/commands/lb.md

@@ -909,8 +909,8 @@ scw lb lb create [arg=value ...]
 | name | Required<br />Default: `<generated>` | Name for the Load Balancer |
 | description |  | Description for the Load Balancer |
 | ~~ip-id~~ | Deprecated | ID of an existing flexible IP address to attach to the Load Balancer |
-| assign-flexible-ip |  | Defines whether to automatically assign a flexible public IP to lb. Default value is `false` (do not assign). |
-| assign-flexible-ipv6 |  | Defines whether to automatically assign a flexible public IPv6 to the Load Balancer. Default value is `false` (do not assign). |
+| assign-flexible-ip | Default: `true` | Defines whether to automatically assign a flexible public IP to the Load Balancer. Default value is `true` (assign). |
+| assign-flexible-ipv6 | Default: `false` | Defines whether to automatically assign a flexible public IPv6 to the Load Balancer. Default value is `false` (do not assign). |
 | ip-ids.{index} |  | List of IP IDs to attach to the Load Balancer |
 | tags.{index} |  | List of tags for the Load Balancer |
 | type | Default: `LB-S`<br />One of: `LB-S`, `LB-GP-M`, `LB-GP-L` | Load Balancer commercial offer type. Use the Load Balancer types endpoint to retrieve a list of available offer types |

internal/namespaces/lb/v1/lb_cli.go

@@ -287,17 +287,19 @@ func lbLBCreate() *core.Command {
 			},
 			{
 				Name:       "assign-flexible-ip",
-				Short:      `Defines whether to automatically assign a flexible public IP to lb. Default value is ` + "`" + `false` + "`" + ` (do not assign).`,
+				Short:      `Defines whether to automatically assign a flexible public IP to the Load Balancer. Default value is ` + "`" + `true` + "`" + ` (assign).`,
 				Required:   false,
 				Deprecated: false,
 				Positional: false,
+				Default:    core.DefaultValueSetter("true"),
 			},
 			{
 				Name:       "assign-flexible-ipv6",
 				Short:      `Defines whether to automatically assign a flexible public IPv6 to the Load Balancer. Default value is ` + "`" + `false` + "`" + ` (do not assign).`,
 				Required:   false,
 				Deprecated: false,
 				Positional: false,
+				Default:    core.DefaultValueSetter("false"),
 			},
 			{
 				Name:       "ip-ids.{index}",