fix(args): parse slice indexes as 32 bits (#2847)

Codelax · web-flow · commit dd77e3cf87c0 · 2023-03-06T15:45:21.000Z
diff --git a/internal/args/unmarshal.go b/internal/args/unmarshal.go
@@ -260,7 +260,7 @@ func set(dest reflect.Value, argNameWords []string, value string) error {
 		}
 
 		// We check if argNameWords[0] is a positive integer to handle cases like keys.0.value=12
-		index, err := strconv.ParseUint(argNameWords[0], 10, 64)
+		index, err := strconv.ParseUint(argNameWords[0], 10, 32) // a slice index is 32 bit
 		if err != nil {
 			return &InvalidIndexError{Index: argNameWords[0]}
 		}

Original file line number	Diff line number	Diff line change
`@@ -260,7 +260,7 @@ func set(dest reflect.Value, argNameWords []string, value string) error {`
`260`	`260`	`}`
`261`	`261`
`262`	`262`	`// We check if argNameWords[0] is a positive integer to handle cases like keys.0.value=12`
`263`		`- index, err := strconv.ParseUint(argNameWords[0], 10, 64)`
	`263`	`+ index, err := strconv.ParseUint(argNameWords[0], 10, 32) // a slice index is 32 bit`
`264`	`264`	`if err != nil {`
`265`	`265`	`return &InvalidIndexError{Index: argNameWords[0]}`
`266`	`266`	`}`