feat(lb): release private lb feature (#3377)

Co-authored-by: Yacine Fodil <[email protected]>

Author: scaleway-bot

cmd/scw/testdata/test-all-usage-lb-private-network-attach-usage.golden

@@ -6,13 +6,13 @@ USAGE:
   scw lb private-network attach <lb-id ...> [arg=value ...]
 
 ARGS:
-  lb-id                 Load Balancer ID
-  private-network-id    Private Network ID
-  [dhcp-config.ip-id]   
-  [zone=fr-par-1]       Zone to target. If none is passed will use default zone from the config (fr-par-1 | fr-par-2 | nl-ams-1 | nl-ams-2 | nl-ams-3 | pl-waw-1 | pl-waw-2)
+  lb-id                Load Balancer ID
+  private-network-id   Private Network ID
+  [zone=fr-par-1]      Zone to target. If none is passed will use default zone from the config (fr-par-1 | fr-par-2 | nl-ams-1 | nl-ams-2 | nl-ams-3 | pl-waw-1 | pl-waw-2)
 
 DEPRECATED ARGS:
   [static-config.ip-address.{index}]   Array of a local IP address for the Load Balancer on this Private Network
+  [dhcp-config.ip-id]                  
 
 FLAGS:
   -h, --help   help for attach

docs/commands/lb.md

@@ -1124,7 +1124,7 @@ scw lb private-network attach <lb-id ...> [arg=value ...]
 | lb-id | Required | Load Balancer ID |
 | private-network-id | Required | Private Network ID |
 | ~~static-config.ip-address.{index}~~ | Deprecated | Array of a local IP address for the Load Balancer on this Private Network |
-| dhcp-config.ip-id |  |  |
+| ~~dhcp-config.ip-id~~ | Deprecated |  |
 | zone | Default: `fr-par-1`<br />One of: `fr-par-1`, `fr-par-2`, `nl-ams-1`, `nl-ams-2`, `nl-ams-3`, `pl-waw-1`, `pl-waw-2` | Zone to target. If none is passed will use default zone from the config |
 
 

internal/namespaces/lb/v1/lb_cli.go

@@ -3260,7 +3260,7 @@ func lbPrivateNetworkAttach() *core.Command {
 			{
 				Name:       "dhcp-config.ip-id",
 				Required:   false,
-				Deprecated: false,
+				Deprecated: true,
 				Positional: false,
 			},
 			core.ZoneArgSpec(scw.ZoneFrPar1, scw.ZoneFrPar2, scw.ZoneNlAms1, scw.ZoneNlAms2, scw.ZoneNlAms3, scw.ZonePlWaw1, scw.ZonePlWaw2),