tests: golden regex replace only actual output (#2747)

Author: Codelax

internal/core/testing.go

@@ -618,10 +618,8 @@ func TestCheckGoldenAndReplacePatterns(replacements ...GoldenReplacement) TestCh
 
 		expected, err := os.ReadFile(goldenPath)
 		require.NoError(t, err, "expected to find golden file %s", goldenPath)
-		expectedString, expectedReplaceErr := goldenReplacePatterns(string(expected), replacements...)
-		assert.Equal(t, expectedString, actual)
+		assert.Equal(t, string(expected), actual)
 		assert.Nil(t, actualReplaceErr, "failed to match test output with regexes")
-		assert.Nil(t, expectedReplaceErr, "failed to match stored golden with regexes")
 	}
 }
 

internal/namespaces/config/commands_test.go

@@ -260,7 +260,7 @@ func Test_ConfigInfoCommand(t *testing.T) {
 	// replace ConfigPath lines with "/tmp/scw/.config/scw/config.yaml"
 	configPathReplacements := []core.GoldenReplacement{
 		{
-			Pattern:     regexp.MustCompile(`(ConfigPath\s).*`),
+			Pattern:     regexp.MustCompile(`(ConfigPath\s+).*`),
 			Replacement: "$1/tmp/scw/.config/scw/config.yaml",
 		},
 		{

internal/namespaces/config/testdata/test-config-info-command-profile.golden

@@ -1,6 +1,6 @@
 🎲🎲🎲 EXIT CODE: 0 🎲🎲🎲
 🟩🟩🟩 STDOUT️ 🟩🟩🟩️
-ConfigPath                       /tmp/scw3107607218/.config/scw/config.yaml
+ConfigPath                       /tmp/scw/.config/scw/config.yaml
 ProfileName                      p1
 Profile.access-key               SCWP1XXXXXXXXXXXXXXX
 Profile.api-url                  https://p1-mock-api-url.com
@@ -11,7 +11,7 @@ Profile.insecure                 true
 Profile.secret-key               11111111-1111-1111-1111-111111111111
 🟩🟩🟩 JSON STDOUT 🟩🟩🟩
 {
-  "ConfigPath": "/tmp/scw3107607218/.config/scw/config.yaml",
+  "ConfigPath": "/tmp/scw/.config/scw/config.yaml",
   "ProfileName": "p1",
   "Profile": {
     "access-key": "SCWP1XXXXXXXXXXXXXXX",

internal/namespaces/config/testdata/test-config-info-command-simple.golden

@@ -1,6 +1,6 @@
 🎲🎲🎲 EXIT CODE: 0 🎲🎲🎲
 🟩🟩🟩 STDOUT️ 🟩🟩🟩️
-ConfigPath                       /tmp/scw1635042996/.config/scw/config.yaml
+ConfigPath                       /tmp/scw/.config/scw/config.yaml
 ProfileName                      default
 Profile.access-key               SCWXXXXXXXXXXXXXXXXX
 Profile.default-organization-id  11111111-1111-1111-1111-111111111111
@@ -11,7 +11,7 @@ Profile.secret-key               11111111-1111-1111-1111-111111111111
 Profile.send-telemetry           true
 🟩🟩🟩 JSON STDOUT 🟩🟩🟩
 {
-  "ConfigPath": "/tmp/scw1635042996/.config/scw/config.yaml",
+  "ConfigPath": "/tmp/scw/.config/scw/config.yaml",
   "ProfileName": "default",
   "Profile": {
     "access-key": "SCWXXXXXXXXXXXXXXXXX",