Skip to content

Commit f29a182

Browse files
chore: deprecate http-option in container and function (#2301)
Co-authored-by: Rémy Léone <[email protected]>
1 parent 89a9d1f commit f29a182

File tree

8 files changed

+20
-12
lines changed

8 files changed

+20
-12
lines changed

cmd/scw/testdata/test-all-usage-container-container-create-usage.golden

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,11 @@ ARGS:
2323
[port]
2424
[secret-environment-variables.{index}.key]
2525
[secret-environment-variables.{index}.value]
26-
[http-option] Configure how HTTP and HTTPS requests are handled
2726
[region=fr-par] Region to target. If none is passed will use default region from the config (fr-par)
2827

28+
DEPRECATED ARGS:
29+
[http-option] Configure how HTTP and HTTPS requests are handled
30+
2931
FLAGS:
3032
-h, --help help for create
3133

cmd/scw/testdata/test-all-usage-container-container-update-usage.golden

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,11 @@ ARGS:
2323
[port]
2424
[secret-environment-variables.{index}.key]
2525
[secret-environment-variables.{index}.value]
26-
[http-option] Configure how HTTP and HTTPS requests are handled
2726
[region=fr-par] Region to target. If none is passed will use default region from the config (fr-par)
2827

28+
DEPRECATED ARGS:
29+
[http-option] Configure how HTTP and HTTPS requests are handled
30+
2931
FLAGS:
3032
-h, --help help for update
3133

cmd/scw/testdata/test-all-usage-function-function-create-usage.golden

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,11 @@ ARGS:
2020
[description]
2121
[secret-environment-variables.{index}.key]
2222
[secret-environment-variables.{index}.value]
23-
[http-option] Configure how HTTP and HTTPS requests are handled
2423
[region=fr-par] Region to target. If none is passed will use default region from the config (fr-par)
2524

25+
DEPRECATED ARGS:
26+
[http-option] Configure how HTTP and HTTPS requests are handled
27+
2628
FLAGS:
2729
-h, --help help for create
2830

cmd/scw/testdata/test-all-usage-function-function-update-usage.golden

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,11 @@ ARGS:
2020
[description]
2121
[secret-environment-variables.{index}.key]
2222
[secret-environment-variables.{index}.value]
23-
[http-option] Configure how HTTP and HTTPS requests are handled
2423
[region=fr-par] Region to target. If none is passed will use default region from the config (fr-par)
2524

25+
DEPRECATED ARGS:
26+
[http-option] Configure how HTTP and HTTPS requests are handled
27+
2628
FLAGS:
2729
-h, --help help for update
2830

docs/commands/container.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ scw container container create [arg=value ...]
5858
| port | | |
5959
| secret-environment-variables.{index}.key | | |
6060
| secret-environment-variables.{index}.value | | |
61-
| http-option | | Configure how HTTP and HTTPS requests are handled |
61+
| ~~http-option~~ | Deprecated | Configure how HTTP and HTTPS requests are handled |
6262
| region | Default: `fr-par`<br />One of: `fr-par` | Region to target. If none is passed will use default region from the config |
6363

6464

@@ -179,7 +179,7 @@ scw container container update <container-id ...> [arg=value ...]
179179
| port | | |
180180
| secret-environment-variables.{index}.key | | |
181181
| secret-environment-variables.{index}.value | | |
182-
| http-option | | Configure how HTTP and HTTPS requests are handled |
182+
| ~~http-option~~ | Deprecated | Configure how HTTP and HTTPS requests are handled |
183183
| region | Default: `fr-par`<br />One of: `fr-par` | Region to target. If none is passed will use default region from the config |
184184

185185

docs/commands/function.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ scw function function create [arg=value ...]
127127
| description | | |
128128
| secret-environment-variables.{index}.key | | |
129129
| secret-environment-variables.{index}.value | | |
130-
| http-option | | Configure how HTTP and HTTPS requests are handled |
130+
| ~~http-option~~ | Deprecated | Configure how HTTP and HTTPS requests are handled |
131131
| region | Default: `fr-par`<br />One of: `fr-par` | Region to target. If none is passed will use default region from the config |
132132

133133

@@ -286,7 +286,7 @@ scw function function update <function-id ...> [arg=value ...]
286286
| description | | |
287287
| secret-environment-variables.{index}.key | | |
288288
| secret-environment-variables.{index}.value | | |
289-
| http-option | | Configure how HTTP and HTTPS requests are handled |
289+
| ~~http-option~~ | Deprecated | Configure how HTTP and HTTPS requests are handled |
290290
| region | Default: `fr-par`<br />One of: `fr-par` | Region to target. If none is passed will use default region from the config |
291291

292292

internal/namespaces/container/v1beta1/container_cli.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -498,7 +498,7 @@ func containerContainerCreate() *core.Command {
498498
Name: "http-option",
499499
Short: `Configure how HTTP and HTTPS requests are handled`,
500500
Required: false,
501-
Deprecated: false,
501+
Deprecated: true,
502502
Positional: false,
503503
},
504504
core.RegionArgSpec(scw.RegionFrPar),
@@ -632,7 +632,7 @@ func containerContainerUpdate() *core.Command {
632632
Name: "http-option",
633633
Short: `Configure how HTTP and HTTPS requests are handled`,
634634
Required: false,
635-
Deprecated: false,
635+
Deprecated: true,
636636
Positional: false,
637637
},
638638
core.RegionArgSpec(scw.RegionFrPar),

internal/namespaces/function/v1beta1/function_cli.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -539,7 +539,7 @@ func functionFunctionCreate() *core.Command {
539539
Name: "http-option",
540540
Short: `Configure how HTTP and HTTPS requests are handled`,
541541
Required: false,
542-
Deprecated: false,
542+
Deprecated: true,
543543
Positional: false,
544544
},
545545
core.RegionArgSpec(scw.RegionFrPar),
@@ -655,7 +655,7 @@ func functionFunctionUpdate() *core.Command {
655655
Name: "http-option",
656656
Short: `Configure how HTTP and HTTPS requests are handled`,
657657
Required: false,
658-
Deprecated: false,
658+
Deprecated: true,
659659
Positional: false,
660660
},
661661
core.RegionArgSpec(scw.RegionFrPar),

0 commit comments

Comments
 (0)