chore: rename 'placement-group' arg to 'placement-group-id' in update server command (#673)

Author: loicbourgois

internal/namespaces/instance/v1/custom_server.go

@@ -176,13 +176,15 @@ func bootscriptMarshalerFunc(i interface{}, opt *human.MarshalOpt) (string, erro
 func serverUpdateBuilder(c *core.Command) *core.Command {
 	type instanceUpdateServerRequestCustom struct {
 		*instance.UpdateServerRequest
-		IP *instance.NullableStringValue
+		IP               *instance.NullableStringValue
+		PlacementGroupID *instance.NullableStringValue
 	}
 
 	IPArgSpec := &core.ArgSpec{
 		Name:  "ip",
 		Short: `IP that should be attached to the server (use ip=none to remove)`,
 	}
+	c.ArgSpecs.GetByName("placement-group").Name = "placement-group-id"
 
 	c.ArgsType = reflect.TypeOf(instanceUpdateServerRequestCustom{})
 
@@ -192,6 +194,7 @@ func serverUpdateBuilder(c *core.Command) *core.Command {
 		customRequest := argsI.(*instanceUpdateServerRequestCustom)
 
 		updateServerRequest := customRequest.UpdateServerRequest
+		updateServerRequest.PlacementGroup = customRequest.PlacementGroupID
 
 		attachIPRequest := (*instance.UpdateIPRequest)(nil)
 

internal/namespaces/instance/v1/custom_server_create.go

@@ -95,7 +95,7 @@ func serverCreateCommand() *core.Command {
 			},
 			{
 				Name:  "placement-group-id",
-				Short: "The security group ID in witch the server has to be created",
+				Short: "The placement group ID in witch the server has to be created",
 			},
 			{
 				Name:  "bootscript-id",

internal/namespaces/instance/v1/custom_server_test.go

@@ -72,4 +72,28 @@ func Test_ServerUpdateCustom(t *testing.T) {
 			return nil
 		},
 	}))
+
+	t.Run("Update server placement-group-id from server with placement-group-id", core.Test(&core.TestConfig{
+		Commands: GetCommands(),
+		BeforeFunc: func(ctx *core.BeforeFuncCtx) error {
+			ctx.Meta["PlacementGroupResponse"] = ctx.ExecuteCmd("scw instance placement-group create")
+			ctx.Meta["PlacementGroupResponse2"] = ctx.ExecuteCmd("scw instance placement-group create")
+			ctx.Meta["Server"] = ctx.ExecuteCmd("scw instance server create stopped=true image=ubuntu-bionic placement-group-id={{ .PlacementGroupResponse.PlacementGroup.ID }}")
+			return nil
+		},
+		Cmd: "scw instance server update server-id={{ .Server.ID }} placement-group-id={{ .PlacementGroupResponse2.PlacementGroup.ID }}",
+		Check: core.TestCheckCombine(
+			func(t *testing.T, ctx *core.CheckFuncCtx) {
+				assert.Equal(t,
+					ctx.Meta["PlacementGroupResponse2"].(*instance.CreatePlacementGroupResponse).PlacementGroup.ID,
+					ctx.Result.(*instance.UpdateServerResponse).Server.PlacementGroup.ID)
+			},
+		),
+		AfterFunc: func(ctx *core.AfterFuncCtx) error {
+			ctx.ExecuteCmd("scw instance server delete server-id={{ .Server.ID }} delete-ip=true delete-volumes=true")
+			ctx.ExecuteCmd("scw instance server delete placement-group-id={{ .PlacementGroupResponse.PlacementGroup.ID }}")
+			ctx.ExecuteCmd("scw instance server delete placement-group-id={{ .PlacementGroupResponse2.PlacementGroup.ID }}")
+			return nil
+		},
+	}))
 }

internal/namespaces/instance/v1/testdata/test-create-server-usage.stderr.golden

@@ -33,7 +33,7 @@ ARGS:
   [ipv6]                         Enable IPv6
   [stopped]                      Do not start server after its creation
   [security-group-id]            The security group ID it use for this server
-  [placement-group-id]           The security group ID in witch the server has to be created
+  [placement-group-id]           The placement group ID in witch the server has to be created
   [bootscript-id]                The bootscript ID to use, if empty the local boot will be used
 
 FLAGS: