fix(analytics): normalize id

Author: philibea

.changeset/hip-carrots-reply.md

@@ -0,0 +1,5 @@
+---
+"@scaleway/use-analytics": patch
+---
+
+Add normalize id on anonymousId, userId, groupId

packages/use-analytics/src/analytics/index.ts

@@ -9,3 +9,4 @@ export type {
 export { userMigrationsTraits } from './segments/userMigrationsTraits'
 export { defaultLoadOptions } from './constants'
 export { useDestinations } from './useDestinations'
+export { normalizeId } from './normalizeId'

packages/use-analytics/src/analytics/normalizeId.ts

@@ -0,0 +1,24 @@
+type ID = string | number | undefined | null
+
+export const normalizeId = (id: ID) => {
+  if (id === null || id === undefined) return undefined
+
+  // Already a string but possibly JSON-encoded
+  if (typeof id === 'string') {
+    try {
+      // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
+      const parsed = JSON.parse(id)
+      // Only use parsed if it’s a string too
+
+      if (typeof parsed === 'string') {
+        return parsed
+      }
+    } catch {
+      // not JSON, keep original
+    }
+
+    return id
+  }
+
+  return String(id)
+}

packages/use-analytics/src/analytics/normalizeIdsMigration.ts

@@ -0,0 +1,25 @@
+import type { RudderAnalytics } from '@rudderstack/analytics-js'
+import { normalizeId } from './normalizeId'
+
+export const normalizeIdsMigration = (rudderAnalytics: RudderAnalytics) => {
+  // normalize id issue with segment migration
+  const anonymousId = rudderAnalytics.getAnonymousId()
+  const normalizeAnonymousId = normalizeId(anonymousId)
+  if (normalizeAnonymousId !== anonymousId) {
+    rudderAnalytics.setAnonymousId(normalizeAnonymousId)
+  }
+
+  const userId = rudderAnalytics.getUserId()
+  const normalizeUserId = userId ? normalizeId(userId) : null
+
+  if (userId !== normalizeUserId && normalizeUserId) {
+    rudderAnalytics.identify(normalizeUserId)
+  }
+
+  const groupId = rudderAnalytics.getGroupId()
+  const normalizeGroupId = groupId ? normalizeId(groupId) : null
+
+  if (userId !== normalizeGroupId && normalizeGroupId) {
+    rudderAnalytics.group(normalizeGroupId)
+  }
+}

packages/use-analytics/src/analytics/segments/userMigrationsTraits.ts

@@ -1,4 +1,5 @@
 import type { RudderAnalytics } from '@rudderstack/analytics-js'
+import { normalizeId } from '../normalizeId'
 
 const SEGMENT_COOKIES_KEY = {
   ANONYMOUS_ID: 'ajs_anonymous_id',
@@ -16,14 +17,20 @@ export const userMigrationsTraits = (rudderAnalytics: RudderAnalytics) => {
   const rudderGroupId = rudderAnalytics.getGroupId()
 
   if (segmentAnonymousId) {
-    rudderAnalytics.setAnonymousId(segmentAnonymousId)
+    rudderAnalytics.setAnonymousId(normalizeId(segmentAnonymousId))
   }
 
   if (segmentUserId && (!rudderUserId || rudderUserId !== segmentUserId)) {
-    rudderAnalytics.identify(segmentUserId)
+    const normalizedUserId = normalizeId(segmentUserId)
+    if (normalizedUserId) {
+      rudderAnalytics.identify(normalizedUserId)
+    }
   }
 
   if (segmentGroupId && (!rudderGroupId || rudderGroupId !== segmentGroupId)) {
-    rudderAnalytics.group(segmentGroupId)
+    const normalizedGroupId = normalizeId(segmentGroupId)
+    if (normalizedGroupId) {
+      rudderAnalytics.group(normalizedGroupId)
+    }
   }
 }

packages/use-analytics/src/analytics/useAnalytics.tsx

@@ -6,6 +6,7 @@ import { useDeepCompareEffectNoCheck } from 'use-deep-compare-effect'
 import { destSDKBaseURL, pluginsSDKBaseURL } from '../constants'
 import type { CategoryKind } from '../types'
 import { defaultConsentOptions, defaultLoadOptions } from './constants'
+import { normalizeIdsMigration } from './normalizeIdsMigration'
 import { userMigrationsTraits } from './segments/userMigrationsTraits'
 
 type Analytics = RudderAnalytics
@@ -130,6 +131,7 @@ export function AnalyticsProvider<T extends Events>({
         pluginsSDKBaseURL: pluginsSDKBaseURL(settings.cdnURL),
         onLoaded: (rudderAnalytics: Analytics) => {
           userMigrationsTraits(rudderAnalytics)
+          normalizeIdsMigration(rudderAnalytics)
 
           rudderAnalytics.consent({
             ...defaultConsentOptions,