Skip to content

Commit 3d05f84

Browse files
author
Tom Lienard
authored
feat(changesets-renovate): create a new commit instead of amend + force push (#1236)
1 parent 345a5d2 commit 3d05f84

File tree

3 files changed

+11
-16
lines changed

3 files changed

+11
-16
lines changed

.changeset/funny-files-roll.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@scaleway/changesets-renovate': patch
3+
---
4+
5+
Create a new commit instead of amend + force push

packages/changesets-renovate/src/__tests__/generate-changeset.ts

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -110,13 +110,8 @@ describe('generate changeset file', () => {
110110
expect(fs.readFile).toHaveBeenCalledWith(file, 'utf8')
111111
expect(fs.writeFile).toMatchSnapshot()
112112
expect(add).toHaveBeenCalledWith(fileName)
113-
expect(commit).toHaveBeenCalledWith([], undefined, {
114-
'-C': null,
115-
HEAD: null,
116-
'--amend': null,
117-
'--no-edit': null,
118-
})
119-
expect(push).toHaveBeenCalledWith(['--force'])
113+
expect(commit).toHaveBeenCalledWith(`Add changeset renovate-${rev}`)
114+
expect(push).toHaveBeenCalledTimes(1)
120115
})
121116

122117
it('should ignore workspace package.json', async () => {

packages/changesets-renovate/src/index.ts

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -98,19 +98,14 @@ export async function run() {
9898
return
9999
}
100100

101-
const shortHash = await simpleGit().revparse(['--short', 'HEAD'])
102-
const fileName = `.changeset/renovate-${shortHash.trim()}.md`
101+
const shortHash = (await simpleGit().revparse(['--short', 'HEAD'])).trim()
102+
const fileName = `.changeset/renovate-${shortHash}.md`
103103
const packageBumps = await getBumps(files)
104104

105105
await createChangeset(fileName, packageBumps, packageNames)
106106
await simpleGit().add(fileName)
107-
await simpleGit().commit([], undefined, {
108-
'-C': null,
109-
HEAD: null,
110-
'--amend': null,
111-
'--no-edit': null,
112-
})
113-
await simpleGit().push(['--force'])
107+
await simpleGit().commit(`Add changeset renovate-${shortHash}`)
108+
await simpleGit().push()
114109
}
115110

116111
run().catch(console.error)

0 commit comments

Comments
 (0)