feat(eslint-config-react): add standalone emotion configuration (#1121)

chambo-e · web-flow · commit 4aa5474f357c · 2022-12-19T11:51:39.000+01:00
* feat(eslint-config-react): add standalone emotion configuration

* fix: correct imports

* fix: correct css prop

* fix: revert
diff --git a/.eslintrc b/.eslintrc
@@ -16,14 +16,14 @@
     {
       "parser": "@babel/eslint-parser",
       "files": ["*.js", "*.mjs"],
-      "extends": "@scaleway/react/index.js"
+      "extends": "@scaleway/react"
     },
     {
       "files": ["*.ts", "*.tsx"],
       "parserOptions": {
         "project": ["tsconfig.json"]
       },
-      "extends": ["@scaleway/react/typescript.js"]
+      "extends": ["@scaleway/react/typescript"]
     }
   ]
 }
diff --git a/packages/eslint-config-react/README.md b/packages/eslint-config-react/README.md
@@ -18,17 +18,25 @@ Add to your `.eslintrc`
 
 ```json
 {
-  "extends": "@scaleway/react"
+  "extends": ["@scaleway/react]"
 }
 ```
 
 Or for Typescript
 
 ```json
 {
-  "extends": "@scaleway/react/typescript",
+  "extends": ["@scaleway/react/typescript"],
   "parserOptions": {
     "project": "./path/to/tsconfig.json"
   }
 }
 ```
+
+We also have a standalong emotion configuration
+
+```json
+{
+  "extends": ["@scaleway/react", "@scaleway/react/emotion"]
+}
+```
diff --git a/packages/eslint-config-react/emotion.js b/packages/eslint-config-react/emotion.js
@@ -0,0 +1,15 @@
+module.exports = {
+  plugins: ['@emotion'],
+  rules: {
+    'react/no-unknown-property': [
+      'error',
+      {
+        ignore: ['css'],
+      },
+    ],
+    '@emotion/import-from-emotion': 'error',
+    '@emotion/no-vanilla': 'error',
+    '@emotion/styled-import': 'error',
+    '@emotion/syntax-preference': ['error', 'string'],
+  },
+}
diff --git a/packages/eslint-config-react/package.json b/packages/eslint-config-react/package.json
@@ -17,6 +17,7 @@
   },
   "license": "MIT",
   "dependencies": {
+    "@emotion/eslint-plugin": "11.10.0",
     "@typescript-eslint/eslint-plugin": "5.46.1",
     "@typescript-eslint/parser": "5.46.1",
     "eslint-config-airbnb": "19.0.4",
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml

Original file line number	Diff line number	Diff line change
`@@ -16,14 +16,14 @@`
`16`	`16`	`{`
`17`	`17`	`"parser": "@babel/eslint-parser",`
`18`	`18`	`"files": [".js", ".mjs"],`
`19`		`- "extends": "@scaleway/react/index.js"`
	`19`	`+ "extends": "@scaleway/react"`
`20`	`20`	`},`
`21`	`21`	`{`
`22`	`22`	`"files": [".ts", ".tsx"],`
`23`	`23`	`"parserOptions": {`
`24`	`24`	`"project": ["tsconfig.json"]`
`25`	`25`	`},`
`26`		`- "extends": ["@scaleway/react/typescript.js"]`
	`26`	`+ "extends": ["@scaleway/react/typescript"]`
`27`	`27`	`}`
`28`	`28`	`]`
`29`	`29`	`}`
Original file line number	Diff line number	Diff line change
@@ -18,17 +18,25 @@ Add to your `.eslintrc`
`18`	`18`
`19`	`19`	```json
`20`	`20`	`{`
`21`		`- "extends": "@scaleway/react"`
	`21`	`+ "extends": ["@scaleway/react]"`
`22`	`22`	`}`
`23`	`23`	```
`24`	`24`
`25`	`25`	`Or for Typescript`
`26`	`26`
`27`	`27`	```json
`28`	`28`	`{`
`29`		`- "extends": "@scaleway/react/typescript",`
	`29`	`+ "extends": ["@scaleway/react/typescript"],`
`30`	`30`	`"parserOptions": {`
`31`	`31`	`"project": "./path/to/tsconfig.json"`
`32`	`32`	`}`
`33`	`33`	`}`
`34`	`34`	```
	`35`	`+`
	`36`	`+We also have a standalong emotion configuration`
	`37`	`+`
	`38`	+```json
	`39`	`+{`
	`40`	`+ "extends": ["@scaleway/react", "@scaleway/react/emotion"]`
	`41`	`+}`
	`42`	+```