feat(changesets-renovate): ignore packages ignored in config (#1531)

* feat(changesets-renovate): ignore packages ignored in config

* fix: remove console log

Author: Tom Lienard

.changeset/honest-vans-chew.md

@@ -0,0 +1,5 @@
+---
+'@scaleway/changesets-renovate': minor
+---
+
+Ignore packages that are ignored in the changeset config

packages/changesets-renovate/src/__tests__/generate-changeset.ts

@@ -104,7 +104,8 @@ describe('generate changeset file', () => {
 
     fs.readFile = jest
       .fn<any>()
-      .mockResolvedValue(`{"name":"packageName","version":"1.0.0"}`)
+      .mockResolvedValueOnce(`{}`)
+      .mockResolvedValueOnce(`{"name":"packageName","version":"1.0.0"}`)
     fs.writeFile = jest.fn<any>()
 
     await run()
@@ -138,7 +139,8 @@ describe('generate changeset file', () => {
 
     fs.readFile = jest
       .fn<any>()
-      .mockResolvedValue(`{"name":"packageName","workspaces":[]}`)
+      .mockResolvedValueOnce(`{}`)
+      .mockResolvedValueOnce(`{"name":"packageName","workspaces":[]}`)
     fs.writeFile = jest.fn<any>()
 
     await run()
@@ -167,7 +169,74 @@ describe('generate changeset file', () => {
 `,
     })
 
-    fs.readFile = jest.fn<any>().mockResolvedValue(`{"name":"packageName"}`)
+    fs.readFile = jest
+      .fn<any>()
+      .mockResolvedValueOnce(`{}`)
+      .mockResolvedValueOnce(`{"name":"packageName"}`)
+    fs.writeFile = jest.fn<any>()
+
+    await run()
+
+    expect(fs.readFile).toHaveBeenCalledWith(file, 'utf8')
+    expect(console.log).toHaveBeenCalledWith('No packages modified, skipping')
+  })
+
+  it('should ignore changeset ignored packages', async () => {
+    const file = 'test/package.json'
+
+    ;(simpleGit as jest.Mock).mockReturnValue({
+      branch: () => ({
+        current: 'renovate/test',
+      }),
+      diffSummary: () => ({
+        files: [
+          {
+            file,
+          },
+        ],
+      }),
+      show: () => `
++ "package": "version"
++ "package2": "version2"
+`,
+    })
+
+    fs.readFile = jest
+      .fn<any>()
+      .mockResolvedValueOnce(`{"ignore":["packageName"]}`)
+      .mockResolvedValueOnce(`{"name":"packageName","version":"1.0.0"}`)
+    fs.writeFile = jest.fn<any>()
+
+    await run()
+
+    expect(fs.readFile).toHaveBeenCalledWith(file, 'utf8')
+    expect(console.log).toHaveBeenCalledWith('No packages modified, skipping')
+  })
+
+  it('should ignore changeset ignored packages with star', async () => {
+    const file = 'test/package.json'
+
+    ;(simpleGit as jest.Mock).mockReturnValue({
+      branch: () => ({
+        current: 'renovate/test',
+      }),
+      diffSummary: () => ({
+        files: [
+          {
+            file,
+          },
+        ],
+      }),
+      show: () => `
++ "package": "version"
++ "package2": "version2"
+`,
+    })
+
+    fs.readFile = jest
+      .fn<any>()
+      .mockResolvedValueOnce(`{"ignore":["@example/*"]}`)
+      .mockResolvedValueOnce(`{"name":"@example/test","version":"1.0.0"}`)
     fs.writeFile = jest.fn<any>()
 
     await run()

packages/changesets-renovate/src/index.ts

@@ -3,7 +3,31 @@
 import fs from 'node:fs/promises'
 import { simpleGit } from 'simple-git'
 
+async function getChangesetIgnoredPackages(): Promise<string[]> {
+  const changesetConfig = JSON.parse(
+    await fs.readFile('.changeset/config.json', 'utf8'),
+  ) as {
+    ignore?: string[]
+  }
+
+  return changesetConfig.ignore ?? []
+}
+
+function shouldIgnorePackage(
+  packageName: string,
+  ignoredPackages: string[],
+): boolean {
+  return ignoredPackages.some(ignoredPackage => {
+    if (ignoredPackage.endsWith('*')) {
+      return packageName.startsWith(ignoredPackage.slice(0, -1))
+    }
+
+    return packageName === ignoredPackage
+  })
+}
+
 async function getPackagesNames(files: string[]): Promise<string[]> {
+  const ignoredPackages = await getChangesetIgnoredPackages()
   const packages: string[] = []
 
   const promises = files.map(async file => {
@@ -13,6 +37,10 @@ async function getPackagesNames(files: string[]): Promise<string[]> {
       version?: string
     }
 
+    if (shouldIgnorePackage(data.name, ignoredPackages)) {
+      return
+    }
+
     // Do not generate changeset for the root package.json of a monorepo
     if (!data.workspaces && data.version) {
       packages.push(data.name)