feat(eslint-config-react): add jsx-key rule (#1746)

johnrazeur · philibea · web-flow · commit 62c3a59d12c2 · 2023-12-28T16:29:01.000+01:00
* feat(eslint-config-react): add jsx-key rule

* fix: disable jsx-key rule for tests

---------

Co-authored-by: philibeaux &lt;aphilibeaux@scaleway.com&gt;
diff --git a/.changeset/shiny-waves-remain.md b/.changeset/shiny-waves-remain.md
@@ -0,0 +1,5 @@
+---
+'@scaleway/eslint-config-react': minor
+---
+
+Add react/jsx-key rule
diff --git a/.eslintrc b/.eslintrc
@@ -38,7 +38,8 @@
         "**/__tests__/**/*.ts{x,}"
       ],
       "rules": {
-        "import/no-extraneous-dependencies": "off"
+        "import/no-extraneous-dependencies": "off",
+        "react/jsx-key": "off"
       }
     }
   ]
diff --git a/packages/eslint-config-react/shared.js b/packages/eslint-config-react/shared.js
@@ -123,5 +123,6 @@ module.exports = {
     ],
     'sort-keys': 'off',
     'no-constant-binary-expression': 'error',
+    'react/jsx-key': 'error',
   },
 }

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +'@scaleway/eslint-config-react': minor
 +---
++
 +Add react/jsx-key rule
Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,8 @@`
`38`	`38`	`"/__tests__//*.ts{x,}"`
`39`	`39`	`],`
`40`	`40`	`"rules": {`
`41`		`- "import/no-extraneous-dependencies": "off"`
	`41`	`+ "import/no-extraneous-dependencies": "off",`
	`42`	`+ "react/jsx-key": "off"`
`42`	`43`	`}`
`43`	`44`	`}`
`44`	`45`	`]`
Original file line number	Diff line number	Diff line change
`@@ -123,5 +123,6 @@ module.exports = {`
`123`	`123`	`],`
`124`	`124`	`'sort-keys': 'off',`
`125`	`125`	`'no-constant-binary-expression': 'error',`
	`126`	`+ 'react/jsx-key': 'error',`
`126`	`127`	`},`
`127`	`128`	`}`