fix(eslint): confict rules (#2324)

Signed-off-by: Alexandre Philibeaux <[email protected]>

Author: philibea

.changeset/strange-pears-tell.md

@@ -0,0 +1,5 @@
+---
+"@scaleway/eslint-config-react": minor
+---
+
+fix conflict rules apply by formatter like prettier / biome

.github/.npmrc

@@ -0,0 +1 @@
+save-prefix=""

package.json

@@ -13,7 +13,7 @@
     "@babel/eslint-parser": "7.25.9",
     "@babel/plugin-transform-runtime": "7.25.9",
     "@babel/preset-env": "7.26.0",
-    "@babel/preset-react": "7.25.9",
+    "@babel/preset-react": "7.26.3",
     "@babel/preset-typescript": "7.26.0",
     "@biomejs/biome": "1.9.4",
     "@changesets/changelog-github": "0.5.0",
@@ -27,7 +27,7 @@
     "@testing-library/react": "16.0.1",
     "@types/jest": "29.5.14",
     "@types/node": "22.10.1",
-    "@types/react": "18.3.12",
+    "@types/react": "18.3.13",
     "@types/react-dom": "18.3.1",
     "@vitejs/plugin-react": "4.3.4",
     "@vitest/coverage-istanbul": "2.1.6",

packages/eslint-config-react/package.json

@@ -35,13 +35,14 @@
   "license": "MIT",
   "dependencies": {
     "@emotion/eslint-plugin": "11.12.0",
-    "@eslint/compat": "1.2.3",
+    "@eslint/compat": "1.2.4",
     "@eslint/eslintrc": "3.2.0",
     "@stylistic/eslint-plugin": "2.11.0",
-    "@typescript-eslint/eslint-plugin": "8.16.0",
-    "@typescript-eslint/parser": "8.16.0",
+    "@typescript-eslint/eslint-plugin": "8.17.0",
+    "@typescript-eslint/parser": "8.17.0",
     "eslint-config-airbnb": "19.0.4",
     "eslint-config-prettier": "9.1.0",
+    "eslint-import-resolver-typescript": "3.7.0",
     "eslint-plugin-deprecation": "3.0.0",
     "eslint-plugin-eslint-comments": "3.2.0",
     "eslint-plugin-import": "2.31.0",
@@ -50,10 +51,10 @@
     "eslint-plugin-react-hooks": "5.0.0"
   },
   "peerDependencies": {
-    "eslint": ">= 9.13"
+    "eslint": ">= 9.x"
   },
   "devDependencies": {
-    "eslint": "9.13.0",
+    "eslint": "9.16.0",
     "typescript": "5.7.2"
   }
 }

packages/eslint-config-react/stylistic.mjs

@@ -15,6 +15,7 @@ const config = compat.extends('airbnb-base')
 
 const defaultAirBnbRules = [...fixupPluginRules(config)].reduce(
   (acc, currentConfig) => ({
+    // biome-ignore lint/performance/noAccumulatingSpread: <explanation>
     ...acc,
     ...currentConfig.rules,
   }),
@@ -31,12 +32,16 @@ export default [
   stylisticPlugin.configs['recommended-flat'],
   {
     rules: {
+      // --- Should be done when using biome/prettier formatter --- //
       '@stylistic/quotes': 'off',
       '@stylistic/operator-linebreak': 'off',
       '@stylistic/indent': 'off',
       '@stylistic/quote-props': 'off',
       '@stylistic/indent-binary-ops': 'off',
       '@stylistic/arrow-parens': 'off',
+      '@stylistic/multiline-ternary': 'off',
+      '@stylistic/no-trailing-spaces': 'off',
+      // -------------------------------------- ///
 
       '@stylistic/brace-style': defaultAirBnbRules['brace-style'],
       '@stylistic/comma-dangle': [

packages/eslint-config-react/typescript.mjs

@@ -19,6 +19,7 @@ export default [
       'airbnb-base',
       'plugin:@typescript-eslint/recommended',
       'plugin:@typescript-eslint/recommended-requiring-type-checking',
+      'plugin:import/typescript',
     ),
   ),
   ...airbnbTypescript,